Skip to content

Loading…

Fix unnecessary HTML-escaped characters #23

Closed
wants to merge 21 commits into from

3 participants

@shinyaohira

Some json files in app/phones directory are HTML-escaped but they are rendered literally.

IgorMinar and others added some commits
@IgorMinar IgorMinar angular-phonecat README.md
added phonecat specific info into the README.md file
edffbb0
@IgorMinar IgorMinar add bootstrap 2.0.3 42aa2af
@IgorMinar IgorMinar add reset flag to jstd to prevent lameness 9b48cbe
@IgorMinar IgorMinar add tutorial related scripts b6eddbb
@IgorMinar IgorMinar add phones.json
- Added a json file with a list of all phones. This file fakes a
  backend which would typically render this list dynamically from
  a database.
83f89bc
@IgorMinar IgorMinar add phone detail json files
- Added one json file with detailed information about each phone
  listed in phones.json
d272b83
@IgorMinar IgorMinar add phone images
- Added images for each phone listed in phones.json
8dfaeac
@IgorMinar IgorMinar empty the angular-seed project
- Initial [angular-seed] project layout without default app and test
  code
23757ff
@IgorMinar IgorMinar step-0 bootstrap angular app
- add ngApp directive to bootstrap the app
- add simple template with an expression
97adc80
@IgorMinar IgorMinar step-1 static phone list
- Added static html list with two phones into index.html
003c7c9
@IgorMinar IgorMinar step-2 angular template with repeater
- Converted the static html list into dynamic one by:
  - creating PhoneListCtrl controller for the application
  - extracting the data from HTML into a the controller as an in-memory
    dataset
  - converting the static document into a template with the use of
    `[ngRepeat]` [directive] which iterates over the dataset with phones,
    clones the ngRepeat template for each instance and renders it into the
    view
- Added a simple unit test to show off how to write tests and run them
  with JsTD (see README.md for instructions)
0b67288
@IgorMinar IgorMinar step-3 interactive search
- Added a search box to demonstrate how:
  - the data-binding works on input fields
  - to use [filter] filter
  - [ngRepeat] automatically shrinks and grows the number of phones in the view
- Added an end-to-end test to:
  - show how end-to-end tests are written and used
  - to prove that the search box and the repeater are correctly wired together
4b1ca41
@IgorMinar IgorMinar step-5 XHR and dependency injection
- Replaced the in-memory dataset with data loaded from the server (in
  the form of static phone.json file to make this tutorial backend
  agnostic)
  - The json file is loaded using the [$http] service
- Demonstrate the use of [services][service] and [dependency injection][DI]
  - The [$http] is injected into the controller through [dependency injection][DI]
86d4e0d
@IgorMinar IgorMinar step-6 phone images and links
- adding phone image and links to phone pages
- add end2end test that verifies our phone links
- css to style the page just a notch
0fe84c1
@IgorMinar IgorMinar step-4 phone ordering
- Add "age" property to the phone model
- Add select box to control phone list order
- Override the default order value in controller
- Add unit and e2e test for this feature
889a4ef
@IgorMinar IgorMinar step-7 $route and app partitioning
- Introduce the [$route] service which allows binding URLs for deep-linking with
  views
  - Create PhoneCatCtrl which governs the entire app and contains $route
    configuration
  - Map `/phones' to PhoneListCtrl and partails/phones-list.html
  - Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html
  - Copy deep linking parameters to root controller `params` property for access
    in sub controllers
  - Replace content of index.html with [ng:view] widget
- Create phone list route
  - Preserve existing PhoneListCtrl controller
  - Move existing html from index.html to partials/phone-list.html
- Create phone details route
  - Empty placeholder PhoneDetailsCtrl controller
  - Empty placeholder partials/phane-details.html template
06f7ba1
@mhevery mhevery step-8 phone details view
- Fetch data for and render phone detail view
  - PhoneDetailCtrl controller to fetch details json with [$xhr] for a specific
    phone
  - template for the phone detailed view
- CSS to make the phone details page look "pretty"
af06cce
@IgorMinar IgorMinar step-9 checkmark filter
- Added custom checkmark filter
- Update phone detail template to use checkmark filter
- Added spec for the filter
a380690
@IgorMinar IgorMinar step-10 image swapping with ng:click
In the phone detail view, clicking on a thumbnail image, changes the
main phone image to be the large version of the thumbnail image.

- Define mainImageUrl model variable in the PhoneDetailCtrl and set its
  default value
- Create setImage controller method to change mainImageUrl
- Register ng:click handler for thumb images to use setImage controller
  method
- Add e2e tests for this feature
- Add css to change the mouse cursor when user points at thumnail images
2987ce7
@IgorMinar IgorMinar step-11 custom service and $resource
- Replaced [$xhr] with [$resource]
- Created a custom Phone service that represents the $resource client
00a0706
@shinyaohira shinyaohira Fix unnecessary HTML-escaped characters 6a20279
@IgorMinar
Angular member

these files are generated by a script in scripts/private/ directory. a proper fix would be to update that script, but I don't think that this change matters that much as it has no impact on the functionality or readability of the code.

@IgorMinar IgorMinar closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 13, 2012
  1. @IgorMinar

    angular-phonecat README.md

    IgorMinar committed with IgorMinar
    added phonecat specific info into the README.md file
  2. @IgorMinar

    add bootstrap 2.0.3

    IgorMinar committed
  3. @IgorMinar
  4. @IgorMinar

    add tutorial related scripts

    IgorMinar committed with IgorMinar
  5. @IgorMinar

    add phones.json

    IgorMinar committed with IgorMinar
    - Added a json file with a list of all phones. This file fakes a
      backend which would typically render this list dynamically from
      a database.
  6. @IgorMinar

    add phone detail json files

    IgorMinar committed with IgorMinar
    - Added one json file with detailed information about each phone
      listed in phones.json
  7. @IgorMinar

    add phone images

    IgorMinar committed with IgorMinar
    - Added images for each phone listed in phones.json
  8. @IgorMinar

    empty the angular-seed project

    IgorMinar committed with IgorMinar
    - Initial [angular-seed] project layout without default app and test
      code
  9. @IgorMinar

    step-0 bootstrap angular app

    IgorMinar committed with IgorMinar
    - add ngApp directive to bootstrap the app
    - add simple template with an expression
  10. @IgorMinar

    step-1 static phone list

    IgorMinar committed with IgorMinar
    - Added static html list with two phones into index.html
  11. @IgorMinar

    step-2 angular template with repeater

    IgorMinar committed with IgorMinar
    - Converted the static html list into dynamic one by:
      - creating PhoneListCtrl controller for the application
      - extracting the data from HTML into a the controller as an in-memory
        dataset
      - converting the static document into a template with the use of
        `[ngRepeat]` [directive] which iterates over the dataset with phones,
        clones the ngRepeat template for each instance and renders it into the
        view
    - Added a simple unit test to show off how to write tests and run them
      with JsTD (see README.md for instructions)
  12. @IgorMinar

    step-3 interactive search

    IgorMinar committed with IgorMinar
    - Added a search box to demonstrate how:
      - the data-binding works on input fields
      - to use [filter] filter
      - [ngRepeat] automatically shrinks and grows the number of phones in the view
    - Added an end-to-end test to:
      - show how end-to-end tests are written and used
      - to prove that the search box and the repeater are correctly wired together
  13. @IgorMinar

    step-5 XHR and dependency injection

    IgorMinar committed with IgorMinar
    - Replaced the in-memory dataset with data loaded from the server (in
      the form of static phone.json file to make this tutorial backend
      agnostic)
      - The json file is loaded using the [$http] service
    - Demonstrate the use of [services][service] and [dependency injection][DI]
      - The [$http] is injected into the controller through [dependency injection][DI]
  14. @IgorMinar

    step-6 phone images and links

    IgorMinar committed with IgorMinar
    - adding phone image and links to phone pages
    - add end2end test that verifies our phone links
    - css to style the page just a notch
  15. @IgorMinar

    step-4 phone ordering

    IgorMinar committed with IgorMinar
    - Add "age" property to the phone model
    - Add select box to control phone list order
    - Override the default order value in controller
    - Add unit and e2e test for this feature
  16. @IgorMinar

    step-7 $route and app partitioning

    IgorMinar committed with IgorMinar
    - Introduce the [$route] service which allows binding URLs for deep-linking with
      views
      - Create PhoneCatCtrl which governs the entire app and contains $route
        configuration
      - Map `/phones' to PhoneListCtrl and partails/phones-list.html
      - Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html
      - Copy deep linking parameters to root controller `params` property for access
        in sub controllers
      - Replace content of index.html with [ng:view] widget
    - Create phone list route
      - Preserve existing PhoneListCtrl controller
      - Move existing html from index.html to partials/phone-list.html
    - Create phone details route
      - Empty placeholder PhoneDetailsCtrl controller
      - Empty placeholder partials/phane-details.html template
  17. @mhevery @IgorMinar

    step-8 phone details view

    mhevery committed with IgorMinar
    - Fetch data for and render phone detail view
      - PhoneDetailCtrl controller to fetch details json with [$xhr] for a specific
        phone
      - template for the phone detailed view
    - CSS to make the phone details page look "pretty"
  18. @IgorMinar

    step-9 checkmark filter

    IgorMinar committed with IgorMinar
    - Added custom checkmark filter
    - Update phone detail template to use checkmark filter
    - Added spec for the filter
  19. @IgorMinar

    step-10 image swapping with ng:click

    IgorMinar committed with IgorMinar
    In the phone detail view, clicking on a thumbnail image, changes the
    main phone image to be the large version of the thumbnail image.
    
    - Define mainImageUrl model variable in the PhoneDetailCtrl and set its
      default value
    - Create setImage controller method to change mainImageUrl
    - Register ng:click handler for thumb images to use setImage controller
      method
    - Add e2e tests for this feature
    - Add css to change the mouse cursor when user points at thumnail images
Commits on Jun 14, 2012
  1. @IgorMinar

    step-11 custom service and $resource

    IgorMinar committed with IgorMinar
    - Replaced [$xhr] with [$resource]
    - Created a custom Phone service that represents the $resource client
Commits on Aug 4, 2012
  1. @shinyaohira
Something went wrong with that request. Please try again.