feat(bower): add npm script for updating bower dependencies as well #384

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

@gkalpak
Member
gkalpak commented Nov 21, 2016

This mainly fixes #383, by adding an npm script (update-deps) for updating bower dependencies as well as npm ones. Previously, is was suggested (in README.md) to run bower update, which would only work if bower was globally installed. Since a global bower installation should not be a prerequisite for the seed project, it is now possible to update bower dependencies via the new update-deps npm script.

The PR includes the following (mostly minor) docs changes in separate commits:

  1. Remove the outdated CloudBees integration.
  2. Highlight the JDK dependency in the "Depedencies" section.
  3. Minor typo/wording/style improvements.
gkalpak added some commits Nov 21, 2016
@gkalpak gkalpak docs(README.md): remove outdated CloudBees integration
The CloudBees URL doesn't seem to work any more. And the
`CloudBees-community/angular-js-clickstart` (now moved to `CloudBees-attic`)
relies on the patched `michaelneale/angular-seed`, which hasn't been updated for
~2.5 years and is more than 40 commits behind `angular/angular-seed`.
3cb9d26
@gkalpak gkalpak feat(*): add npm script for updating bower dependencies as well
Previously, is was suggested to run `bower update`, which would only work if `bower` was globally
installed. Since a global `bower` installation should not be a prerequisite for the seed project, it
is now possible to update bower dependencies via the new `update-deps` npm script.

Fixes #383
f698f32
@gkalpak gkalpak docs(README.md): highlight the JDK dependency in the "Depedencies" se…
…ction
2774dab
@gkalpak gkalpak docs(README.md): minor typo/wording/style improvements
f3a7cef
@gkalpak
Member
gkalpak commented Nov 21, 2016
README.md
-correctly. Therefore, our web server needs to be serving up the application, so that Protractor
-can interact with it.
+correctly. Therefore, our web server needs to be serving up the application, so that Protractor can
+interact with it. Before starting Protractor, open a separate terminal window and run:
@petebacondarwin
petebacondarwin Nov 21, 2016 Member

Is it worth putting this line in its own paragraph? And maybe even making it bold?

@petebacondarwin
Member

LGTM - one small suggestion

@gkalpak gkalpak closed this in 9ca1782 Nov 21, 2016
@gkalpak gkalpak deleted the gkalpak:feat-bower-update-without-global-installation branch Nov 21, 2016
@petebacondarwin
Member

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment