Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Cleaned up output of batch files. Added watchr script that runs on windows#4

Closed
ifedotov wants to merge 2 commits into
angular:masterfrom
ifedotov:cleanup-batch-files-add-watchr-win
Closed

Cleaned up output of batch files. Added watchr script that runs on windows#4
ifedotov wants to merge 2 commits into
angular:masterfrom
ifedotov:cleanup-batch-files-add-watchr-win

Conversation

@ifedotov

Copy link
Copy Markdown
Contributor

batch files didn't have echo off so the output displayed unnecessary lines
also since I got watchr to work on windows (it should probably run on other platforms too) I also added echo off to test.bat so as not to clutter the log file with commands

@IgorMinar

Copy link
Copy Markdown
Contributor

ok, now I see why the watchr script didn't work for you. I forgot that it uses many unix commands.

I would much prefer to have one watchr script for both *nix and wndows and have the script figure out where its running and then do the right thing.

You can take a stab at this, or I'll use your windows script to create one that works in both cases.

@ifedotov

Copy link
Copy Markdown
Contributor Author

I think my script should work on *nix as is because it uses ruby commands rather then system. And the paths are relative.
I have an ubuntu laptop I should be able to test it on, though I haven't touched it for some time.
If you are not on windows you should be able to test it easily too I think.
One thing though is I couldn't get it go up the folder tree. In the original script there is cd .. that didn't work for me for some reason. And regex in watch() would not respond to ../ or c:/ it seemed to work only down the tree.
I was going to look at watchr code but I am not a ruby developer so I am not sure I am ready to hack it up. It would be nice to have it print a list of paths it's watching when you fire it up

@katowulf

Copy link
Copy Markdown

Thanks for the watchr script; this worked well for me; can't wait to see it in the seed!

@IgorMinar

Copy link
Copy Markdown
Contributor

the switch to Testacular made all of these changes obsolete.

thanks for the contribution thought!

@IgorMinar IgorMinar closed this Oct 18, 2012
adriantoczydlowski pushed a commit to adriantoczydlowski/angular-seed that referenced this pull request Sep 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants