perf(compiler): 45x speedup. Cache the attribute keys.

dart-archive · Apr 3, 2014 · 556ef5c · 556ef5c
1 parent b52323e
commit 556ef5c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/core_dom/selector.dart b/lib/core_dom/selector.dart
@@ -202,9 +202,14 @@ class _ElementSelector {
     return partialSelection;
   }
 
+  // A global cache for the _matchingKey RegExps.  The size is bounded by
+  // the number of attribute directive selectors used in the application.
+  static var _matchingKeyCache = <String, RegExp>{};
+
   String _matchingKey(Iterable<String> keys, String attrName) =>
       keys.firstWhere((key) =>
-          new RegExp('^${key.replaceAll('*', r'[\w\-]+')}\$')
+          _matchingKeyCache.putIfAbsent(key,
+                  () => new RegExp('^${key.replaceAll('*', r'[\w\-]+')}\$'))
               .hasMatch(attrName), orElse: () => null);
 
   toString() => 'ElementSelector($name)';