Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add "set title" cookbook by Ben Nadel #1069
Hi Ben -
I've tweaked it to get around the rough spots, illustrate some of our elements of style, and open some possibilities for the future.
The plunker is working now. I'm not sure what was wrong or how I fixed it. There were some HTML tags that weren't quite correct (
It may have been the tabs. All of our code samples use two spaces for tabs. I converted your code accordingly. Please set your environment to do that automagically.
Other style points
As other author's know, I have a hard time keeping my hands off the prose. I elaborated on why you are right to register the Title service in bootstrap when we almost always register application wide services in the root
I added the observation that one could grab the
The plunker doesn't show the title changing. This is a problem I first encountered with routing. I provided a little instruction to show you can see the change in pop-up window mode.
Tell me when it's ready!
There is a future task that I hid in Jade comments ... how to use the Title service to set the back/forward buttons in navigation. Maybe you'll take that on at some point. We can talk about it.
But I'd be happy to publish now ... or as soon as you give the signal that you think it is ready ... and someone adds an e2e test
@wardbell thank you for the in-depth feedback. I can totally get on board with the syntax and prose style for the docs. And certainly no worries about editing the prose yourself - I assume you have a better holistic sense of continuity than anyone else here, so do what you think is right.
I did try looking at the e2e testing, but was very unclear on how they worked (I'm honestly not a big tester yet). I will try to dig in a bit more.
@wardbell I think the edits you made are solid. I left one question about one of the code-snippets; but otherwise, I think I understand the style that you guys are using.
I still have to add the e2e tests. I will get that done this week - but may need some help with figuring out how to do that.
After this is all done, I will be much better with my iterations - once I have my bearings, it will flow more naturally.
Where did I do
I thought I was pretty darned clear that wouldn't work ... although I neglected to make it look like a binding so I MUST do that to complete the example.
Do you see any ambiguity there? ;-)