This repository has been archived by the owner. It is now read-only.

Adds “Edit on GitHub” link #11

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@kennethormandy
Copy link

kennethormandy commented Mar 20, 2015

Hey! Awesome work on this site, it looks great. This pull request adds a little snippet we use on the Harp docs to let people know they contribute.

screen shot 2015-03-20 at 11 03 44 am

The link will fork the project for them and open up the editing view on GitHub. Feel free to use as much or as little of this as you’d like :)

@alexwolfe

This comment has been minimized.

Copy link
Contributor

alexwolfe commented Mar 20, 2015

@kennethormandy this is a cool idea and thanks so much for the contribution. However, I don't want folks to exit the flow on this page to github. The the next CTA will be geared toward viewing the guide in order to continue the learning process.

We have already given top billing to "Contribute" in the main navigation. It's now one of only 4 links in the navigation (25%) which I think it exceptionally high priority given the real estate.

That said, perhaps there is a more subtle way to include something like this. I'm going to close this pull for now but play around with designs ideas that could work for incorporating something like this. Again, great idea, l'll def play around with this.

@alexwolfe alexwolfe closed this Mar 20, 2015

@kennethormandy

This comment has been minimized.

Copy link

kennethormandy commented Mar 20, 2015

Cool! That totally makes sense. I mostly just wanted to share the snippet, if it comes in handy later on that’s great too.

@alexwolfe

This comment has been minimized.

Copy link
Contributor

alexwolfe commented Mar 20, 2015

Thanks @kennethormandy I'm sure it will. Appreciate you sharing this 👍

Dotneteer referenced this pull request in IdeaBlade/angular.io Nov 18, 2015

Dotneteer referenced this pull request in IdeaBlade/angular.io Nov 24, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.