Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
docs(a11y-sweep): Apply baseline accessibility to the examples #1613
** DO NOT MERGE **
Starting with a11y sweep on the examples.
Background: The examples need to, where possible, comply with at least a minimum of accessibility features.
To kick off the sweep and discussion I have made a few subtle changes to the TOH-1 example app.
These kinds of accessibility issues can be fixed purely in HTML and CSS.
changed the title from
[WIP] docs(a11y-sweep): Apply baseline accessibility to the examples
docs(a11y-sweep): Apply baseline accessibility to the examples
Jun 9, 2016
These would either conflict with the purpose of the example or make it overly complex. Recommendation to add a note on this later.
Applied all changes mentioned with TOH-2 where applicable in the new layout. Added similar fixes to the menu dashboard.
Also similar exclusions.
Also did not add focus management and notifications to the screen reader for asynchronous content/actions
As suggested before these could be added as notes/comments in the docs.
Header levels on
TOH application refactor complete.
Based on this I would make the following recommendations.
The following actions I recommend as MUST HAVE:
The examples must play reasonably well with screen readers. This means:
The following action I recommend as SHOULD HAVE:
Further accessibility functions such as complex focus management and other
Also implementation of full
IMPORTANT: All these points are MUST HAVE in real world applications.
Lets make a call on what is in and what is out.
I like all of that.
What I would personally do is: Add all those things that doesn't really change the game. Changing invalid
For big game changers, say adding new events for keyboard, the
What do you think (both @wardbell and @AlmeroSteyn) if we create a new kind of "section" (you know, a colored block) for a11y? A11y is a real thing, we should promote it everywhere and we could add this colored section (in green, I like green) with extra information.
For example in this case, we can add a bit of text + snippet to say that we add a
At least for the tutorial, we need to teach the best practices there.