This repository has been archived by the owner. It is now read-only.

[WIP] docs(router): Upgraded developer guide to new router #1636

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@brandonroberts
Contributor

brandonroberts commented Jun 9, 2016

Please do not merge before consulting Ward or on morning of June 16, which ever comes first.

@googlebot googlebot added the CLA: yes label Jun 9, 2016

@brandonroberts

This comment has been minimized.

Contributor

brandonroberts commented Jun 9, 2016

@wardbell this one is ready for review

:marked
### *<base href>*
Most routing applications should add a `<base>` element to the **`index.html`** just after the `<head>` tag

This comment has been minimized.

@zoechi

zoechi Jun 12, 2016

This might be confusing. It can be interpreted it as

<head>
   stuff
</head>
<base ...>

but it should rather be

<head>
  <base ...>
   stuff
</head>

I would write "as first child in <head>"

This comment has been minimized.

@Foxandxss

Foxandxss Jun 12, 2016

Member

Yes, that is confusing. "First child" or "inside it". Something like that would be good.

This comment has been minimized.

@brandonroberts

brandonroberts Jun 12, 2016

Contributor

Good catch

:marked
### Let's summarize
The application is provide a router configured with routes.

This comment has been minimized.

@zoechi

zoechi Jun 12, 2016

This sentence is weird. Might be my poor English knowledge though.

This comment has been minimized.

@Foxandxss

Foxandxss Jun 12, 2016

Member

No, it is definitely weird.

This comment has been minimized.

@brandonroberts

brandonroberts Jun 12, 2016

Contributor

Yea that's a typo on my part.

@googlebot

This comment has been minimized.

googlebot commented Jun 13, 2016

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

1 similar comment
@googlebot

This comment has been minimized.

googlebot commented Jun 13, 2016

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@ocombe

This comment has been minimized.

Collaborator

ocombe commented Jun 15, 2016

You should add something on async routes and lazy loading components :-)

@wardbell wardbell changed the title from docs(router): Upgraded developer guide to new router to [WIP] docs(router): Upgraded developer guide to new router Jun 15, 2016

@googlebot

This comment has been minimized.

googlebot commented Jun 16, 2016

CLAs look good, thanks!

1 similar comment
@googlebot

This comment has been minimized.

googlebot commented Jun 16, 2016

CLAs look good, thanks!

@naomiblack

This comment has been minimized.

Member

naomiblack commented Jun 16, 2016

merged!

@naomiblack naomiblack closed this Jun 16, 2016

// #docregion
// #docregion route-config
export const routes: RouterConfig = [

This comment has been minimized.

@imcotton

imcotton Jun 17, 2016

@brandonroberts I think it should be as:

export const routes = RouterConfig([
]);

edited: oh, the RouterConfig is type declaration from TS, my bad.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.