Skip to content
Permalink
Browse files

refactor(jqLite): wrap the jqueryVersion binding in a span

Protractor's by.binding selector selects the whole element in which the binding
is contained as otherwise it can't know which bit of text has been interpolated.

It's safer to wrap the binding in a span so that we're sure what the e2e tests
are exactly testing.
  • Loading branch information
mgol authored and petebacondarwin committed Oct 9, 2016
1 parent a02c886 commit 138fbf0d6c609c7d926b9dff10472d68efab8457
Showing with 2 additions and 2 deletions.
  1. +1 −1 test/e2e/fixtures/ng-jq-jquery/index.html
  2. +1 −1 test/e2e/fixtures/ng-jq/index.html
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html ng-app="test" ng-jq="jQuery_2_1_0">
<body>
{{jqueryVersion}}
<span>{{jqueryVersion}}</span>

<script src="http://ajax.googleapis.com/ajax/libs/jquery/2.1.0/jquery.min.js"></script>
<script>
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html ng-app="test" ng-jq>
<body>
{{jqueryVersion}}
<span>{{jqueryVersion}}</span>

<script src="../../../../bower_components/jquery/dist/jquery.js"></script>
<script type="text/javascript">

0 comments on commit 138fbf0

Please sign in to comment.
You can’t perform that action at this time.