Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

fix(ngView): ensure ngClass works with together with ngView's transcl…

…usion behavior

Closes: #3727
  • Loading branch information...
commit 40c0220c47c620070b30aec6ec4552c68a8689eb 1 parent 36ad40b
@matsko matsko authored mhevery committed
View
1  src/ngRoute/directive/ngView.js
@@ -176,6 +176,7 @@ function ngViewFactory( $route, $anchorScroll, $compile, $controller,
return {
restrict: 'ECA',
terminal: true,
+ priority: 1000,
transclude: 'element',
compile: function(element, attr, linker) {
return function(scope, $element, attr) {
View
40 test/ngRoute/directive/ngViewSpec.js
@@ -600,6 +600,46 @@ describe('ngView animations', function() {
expect(itemA).not.toEqual(itemB);
var itemB = $animate.flushNext('enter').element;
}));
+
+ it('should render ngClass on ngView',
+ inject(function($compile, $rootScope, $templateCache, $animate, $location, $timeout) {
+
+ var item;
+ $rootScope.tpl = 'one';
+ $rootScope.klass = 'classy';
+ element = $compile(html('<div><div ng-view ng-class="klass"></div></div>'))($rootScope);
+ $rootScope.$digest();
+
+ $location.path('/foo');
+ $rootScope.$digest();
+
+ item = $animate.flushNext('enter').element;
+
+ $animate.flushNext('addClass').element;
+ $animate.flushNext('addClass').element;
+
+ expect(item.hasClass('classy')).toBe(true);
+
+ $rootScope.klass = 'boring';
+ $rootScope.$digest();
+
+ $animate.flushNext('removeClass').element;
+ $animate.flushNext('addClass').element;
+
+ expect(item.hasClass('classy')).toBe(false);
+ expect(item.hasClass('boring')).toBe(true);
+
+ $location.path('/bar');
+ $rootScope.$digest();
+
+ $animate.flushNext('leave').element;
+ item = $animate.flushNext('enter').element;
+
+ $animate.flushNext('addClass').element;
+ $animate.flushNext('addClass').element;
+
+ expect(item.hasClass('boring')).toBe(true);
+ }));
});
it('should not double compile when the route changes', function() {
Please sign in to comment.
Something went wrong with that request. Please try again.