From 833eb3c84445110dc1dad238120573f08ed8d102 Mon Sep 17 00:00:00 2001 From: Igor Minar Date: Tue, 18 Oct 2011 16:46:27 -0700 Subject: [PATCH] fix(ng:repeat): repeater should ignore $ and $$ properties --- src/widgets.js | 2 +- test/widgetsSpec.js | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/widgets.js b/src/widgets.js index f1f464198cbb..423fe6dd69c9 100644 --- a/src/widgets.js +++ b/src/widgets.js @@ -373,7 +373,7 @@ angularWidget('@ng:repeat', function(expression, element){ cursor = iterStartElement; // current position of the node for (key in collection) { - if (collection.hasOwnProperty(key)) { + if (collection.hasOwnProperty(key) && key.charAt(0) != '$') { last = lastOrder.shift(value = collection[key]); if (last) { // if we have already seen this object, then we need to reuse the diff --git a/test/widgetsSpec.js b/test/widgetsSpec.js index b6754b91bd9c..905553258898 100644 --- a/test/widgetsSpec.js +++ b/test/widgetsSpec.js @@ -290,6 +290,28 @@ describe("widget", function() { expect(element.text()).toEqual('misko:m:first|shyam:s:last|'); }); + it('should ignore $ and $$ properties', function() { + var scope = compile(''); + scope.items = ['a', 'b', 'c']; + scope.items.$$hashkey = 'xxx'; + scope.items.$root = 'yyy'; + scope.$digest(); + + expect(element.text()).toEqual('a|b|c|'); + }); + + it('should repeat over nested arrays', function() { + var scope = compile(''); + scope.groups = [['a', 'b'], ['c','d']]; + scope.$digest(); + + expect(element.text()).toEqual('a|b|Xc|d|X'); + }); + describe('stability', function() { var a, b, c, d, scope, lis;