New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ngMessages): allow using template tags for included messages #10846

Closed
PascalPrecht opened this Issue Jan 23, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@PascalPrecht
Contributor

PascalPrecht commented Jan 23, 2015

Since we're able to predefine messages in <script> tags and include them at later time at different places using ng-messages-include (more detail here: #10844), wouldn't it be cool to also being able to use <template> tags instead of only hacky <script type="text/ng-template"> tags? Because, this is what they are designed for. Templates.

In order to clone the contents of a <template> we just need to access it's content property, so it shouldn't be too hard to implement it.

Wdyt?

(also, Angular 1.x would then have official support for some Web Components technology then :))

@petebacondarwin

This comment has been minimized.

Member

petebacondarwin commented Jan 24, 2015

So the HTML5 <template> element is not supported in IE. So how would we ensure that this works across the board?

If we did do this then we would want to do it for all templates (i.e. for directive and ng-include) too.

@just-boris

This comment has been minimized.

Contributor

just-boris commented Jan 31, 2015

It's a good feature for 2.0 version

@matsko

This comment has been minimized.

Member

matsko commented Feb 11, 2015

This won't be going into 1.x. Please make a comment inside angular/angular for it to go into 2.0.

@matsko matsko closed this Feb 11, 2015

@PascalPrecht

This comment has been minimized.

Contributor

PascalPrecht commented Feb 25, 2015

Oh just seeing that there've been a discussion on that one. Okay, I'm going to open one up on the angular 2 repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment