Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate assumes transition is linear instead of using the value in CSS #12656

Open
wesleycho opened this issue Aug 22, 2015 · 4 comments · May be fixed by #13488
Open

ngAnimate assumes transition is linear instead of using the value in CSS #12656

wesleycho opened this issue Aug 22, 2015 · 4 comments · May be fixed by #13488
Assignees
@Narretz
Labels
component: ngAnimate frequency: high severity: regression type: bug
Milestone
Backlog - won't fix

Comments

@wesleycho
Copy link
Contributor

There are two scenarios which are not being caught - the easing function in CSS when the transition is specified in the transition CSS property, and the easing function if it is specified in the transition-timing-function property.

Here is a stripped down example of the transition-timing-function situation.

Here is a plnkr, a stripped down example of the transition situation.

Note that $animateCss (& $animate as well it turns out) assumes that the easing function is linear instead of ease here.

This is a regression from 1.3.x
@wesleycho wesleycho mentioned this issue Aug 22, 2015
Closed
@Narretz Narretz added this to the 1.4.5 milestone Aug 23, 2015
@Narretz
Copy link
Contributor

Narretz commented Aug 24, 2015

Thanks for reporting @wesleycho! Contrary to many other ngAnimate bug, this looks like it's not too difficult to fix. Do you think you could give a PR a shot?

@wesleycho
Copy link
Contributor Author

Sure, I'll try to put together a PR today

@wesleycho wesleycho mentioned this issue Aug 24, 2015
Closed
@Narretz Narretz modified the milestones: 1.4.5, 1.4.6 Aug 31, 2015
@trajano
Copy link

trajano commented Sep 5, 2015

Here's a plnkr that you can use http://plnkr.co/edit/rHRFzotMG5pZGeBKF8Lw?p=preview

@petebacondarwin petebacondarwin modified the milestones: 1.4.6, 1.4.7 Sep 17, 2015
@Narretz Narretz modified the milestones: 1.4.7, 1.4.8 Oct 1, 2015
@Narretz Narretz self-assigned this Nov 17, 2015
@Narretz Narretz mentioned this issue Nov 18, 2015
Closed
@Narretz Narretz modified the milestones: 1.4.8, 1.4.9 Nov 26, 2015
@Narretz Narretz closed this as completed in de9777d Dec 9, 2015
matsko pushed a commit to matsko/angular.js that referenced this issue Dec 9, 2015
@Narretz @matsko
fix($animateCss): respect transition styles already on the element
7677c1c 
Previously, $animateCss wouldn't use transition styles that were on the element
before the animation process started. Precisely, transition property, timing-function
and delay were overwritten in the process.

Closes angular#12656
Closes angular#13333
Narretz added a commit to Narretz/angular.js that referenced this issue Dec 10, 2015
@Narretz
fix($animateCss): respect transition styles already on the element
aed81cb 
Previously, $animateCss wouldn't use transition styles that were on the element
before the animation process started. Precisely, transition property, timing-function
and delay were overwritten in the process.

Closes angular#12656
Closes angular#13333
@Narretz Narretz linked a pull request Dec 10, 2015 that will close this issue
Open
@Narretz
Copy link
Contributor

Narretz commented Dec 10, 2015

We had some issues on Travis, so the commit was reverted

@Narretz Narretz reopened this Dec 10, 2015
Narretz added a commit to Narretz/angular.js that referenced this issue Dec 17, 2015
@Narretz
fix($animateCss): respect transition styles already on the element
f1fda8f 
Previously, $animateCss wouldn't use transition styles that were on the element
before the animation process started. Precisely, transition property, timing-function
and delay were overwritten in the process.

Closes angular#12656
Closes angular#13333
@petebacondarwin petebacondarwin modified the milestones: 1.4.9, 1.4.10 Jan 21, 2016
@petebacondarwin petebacondarwin modified the milestones: 1.4.10, 1.5.1 Jan 28, 2016
@Narretz Narretz modified the milestones: 1.5.1, 1.5.x Feb 15, 2016
@wesleycho wesleycho mentioned this issue Feb 24, 2016
Closed
@Narretz Narretz modified the milestones: 1.5.x, Backlog Apr 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Narretz Narretz

Labels
component: ngAnimate frequency: high severity: regression type: bug
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

[don't merge]: fix($animateCss): respect transition styles already on the element Narretz/angular.js
4 participants
@petebacondarwin @trajano @Narretz @wesleycho