Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date filter (still) shows incorrect month names for Slavic languages #13999

Closed
Janneman84 opened this Issue Feb 10, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@Janneman84
Copy link

commented Feb 10, 2016

As a follow up of this issue:
#10247

Languages like Polish and Croatian have different versions of months names depending on the context.

The Angular's localization files now have both versions present ("MONTH" and "STANDALONEMONTH"). But the date filter doesn't seems to be always using the right ones, actually it still only seems to use the "MONTH" version at all times

For example if you use "MMMM" to just get the month's name it should show the version from "STANDALONEMONTH".

Would it be possible to at least make the plain "MMMM" one behave correctly? Because if it does then AngularUI's datepicker will work correctly too. Thanks.

Or introduce a new code, like five M's ('MMMMM') or something for the standalone version so people can choose themselves what version should be used.

I'm on 1.4.9 by the way.

@Narretz

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2016

@Janneman84 do you want to give a PR for this a try?

@gkalpak

This comment has been minimized.

Copy link
Member

commented Feb 11, 2016

I couldn't find it properly documented anywhere, but the Closure Library (which we get our locale data from), seem to be using LLLL for STANDALONEMONTH (e.g. see here and in other places in the source code).

I think it's reasonable to use LLLL as well. There seems also to be the LLL pattern for STANDALONESHORTMONTH, but we are not extracting that information (so I don't think we need LLL until someone asks for it - then we can consider it 😃).

@Janneman84

This comment has been minimized.

Copy link
Author

commented Feb 12, 2016

Using 'LLLL' sounds good, I'm looking forward for a PR or update.

'LLL' for short standalone month doesn't seem really necessary because it's the last part of the month's names that is different so the short versions are the same anyway. Maybe there is an exception somewhere, but at least not in Polish or Croatian.

@gkalpak

This comment has been minimized.

Copy link
Member

commented Feb 13, 2016

I'm looking forward for a PR or update.

@Janneman84, LLLL has been already implemented in #14013 has been merged into master and v1.5.x 😃
It will be available in the 1.5.1 release onwards. You can try the latest code from master using https://code.angularjs.org/snapshot/angular.js.

LeeAdcock added a commit to LeeAdcock/angular.js that referenced this issue Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.