Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upng-change doesn't get the $event argument #6370
Closed
Labels
Comments
|
|
|
So sorry to resurrect this @caitp , but could you point me in the right direction if I wanted to handle (and possibly preventDefault) a change event? Specifically thinking about a |
|
use jQuery#on() or jqLite#on() to bind event listeners, and call preventDefault() if you need to |
asfgit
pushed a commit
to apache/zeppelin
that referenced
this issue
May 4, 2017
### What is this PR for? `ng-change` can not capture event, so that means `$event.timeStamp` is undefined. angular/angular.js#6370 This cause AngularElem's onChange is only invoked once. This PR use another approach to update the angularObject. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-2486 ### How should this be tested? Tested manually ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #2312 from zjffdu/ZEPPELIN-2486 and squashes the following commits: 4039d6b [Jeff Zhang] ZEPPELIN-2486. AngularElem's onChange is only invoked once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When you attach a listener to a radio button with ng-change yout can't pass an $event argument.
If I change ng-change to ng-click it does the trick, but it will be better if $event is available for the different event-listeners defined by angular directives