This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat($http): add xhr statusText to completeRequest callback #6713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
OK, looks good to me. But I think in 2.0 we should be passing around some kind of object rather than having to code up each parameter individually. |
| @@ -148,12 +149,19 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc | |||
| // while retrieving files from application cache. | |||
| if (status === 0) { | |||
| status = response ? 200 : urlResolve(url).protocol == 'file' ? 404 : 0; | |||
|
|
|||
| if (!statusText) { | |||
| statusText = status === 200 ? 'OK' : status === 404 ? 'Not Found' : 'Error'; | |||
There was a problem hiding this comment.
why should we do this? if there was no status text (which is rare) then we should not try to correct that IMO
There was a problem hiding this comment.
what if we move this to the ngMock code?
|
the rest looks good |
Makes xhr status text accessible is $http success/error callback. See www.w3.org/TR/XMLHttpRequest/#dom-xmlhttprequest-statustext Closes angular#2335
|
lgtm |
|
Thanks Igor, I'll merge today |
caitp
pushed a commit
that referenced
this pull request
Mar 27, 2014
Makes xhr status text accessible is $http success/error callback. See www.w3.org/TR/XMLHttpRequest/#dom-xmlhttprequest-statustext Closes #2335 Closes #2665 Closes #6713
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes xhr status text accessible is $http success/error callback. See
www.w3.org/TR/XMLHttpRequest/#dom-xmlhttprequest-statustext
(This is just a rebased version of the other PR (#2665), meant to fix the bitrot so it can be merged.
Review is needed!)
Closes #2335
Closes #2665