feat(limitTo): ignore limit when undefined #10510

marcin-wosinek · 2014-12-17T23:26:38Z

BREAKING CHANGE: limitTo changed behavoir when limit value is undefined.
Instead of returning empty object/array it returns non-changed input.

Closes #10484

googlebot · 2014-12-17T23:26:40Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot · 2014-12-17T23:29:25Z

CLAs look good, thanks!

gkalpak · 2014-12-18T10:43:46Z

src/ng/filter/limitTo.js

@@ -15,7 +15,8 @@
 * @param {string|number} limit The length of the returned array or string. If the `limit` number
 *     is positive, `limit` number of items from the beginning of the source array/string are copied.
 *     If the number is negative, `limit` number  of items from the end of the source array/string
- *     are copied. The `limit` will be trimmed if it exceeds `array.length`
+ *     are copied. The `limit` will be trimmed if it exceeds `array.length`. If `limit` is undefined,
+ *     the input will be left unchanged.


IMO, "returned" is more appropriate than "left" (since the input is left unchanged in any case).

gkalpak · 2014-12-18T10:46:47Z

src/ng/filter/limitTo.js

    } else {
      // zero and NaN check on limit - return empty array
-      if (!limit) return [];
+      if (!limit) return input.slice();


This will never evaluate to true with the current implementation.

gkalpak · 2014-12-18T10:48:47Z

test/ng/filter/limitToSpec.js

+    expect(limitTo(items, 'null')).toEqual(items);
+    expect(limitTo(items, 'undefined')).toEqual(items);
+    expect(limitTo(items, null)).toEqual(items);
+    expect(limitTo(items, undefined)).toEqual(items);


There should also be a test with 0 (to ensure it works as expected).

UPDATE: Has been added.

gkalpak · 2014-12-18T10:48:52Z

test/ng/filter/limitToSpec.js

+    expect(limitTo(str, 'null')).toEqual(str);
+    expect(limitTo(str, 'undefined')).toEqual(str);
+    expect(limitTo(str, null)).toEqual(str);
+    expect(limitTo(str, undefined)).toEqual(str);


There should also be a test with 0 (to ensure it works as expected).

UPDATE: Has been added.

gkalpak · 2014-12-18T10:55:16Z

I have left a couple of minor comments inline.

Additionally, I believe a little refactoring is in place: it would be better (i.e. more maintainable/performant) to do the NaN check sooner in the code (and return the input itself), so we can (1) "fail fast" and (2) avoid some of the else blocks further down.

But "functionality-wise" it should be OK.

BTW, the commit message and breaking change notice are slightly inaccurate: It is not only undefined but any invalid value, right ?

marcin-wosinek · 2014-12-18T13:46:02Z

@gkalpak thanks for the review

marcin-wosinek · 2014-12-18T15:06:24Z

I'm lost with the build result. I get:

No output has been received in the last 10 minutes, this potentially indicates 
a stalled build or something wrong with the build itself.

The build has been terminated

from job 1.

gkalpak · 2014-12-18T15:30:13Z

test/ng/filter/limitToSpec.js

-    expect(limitTo(items, null)).toEqual([]);
-    expect(limitTo(items, undefined)).toEqual([]);
+  it('should return an empty array when X = 0', function() {
+    expect(limitTo(items, 0)).toEqual([]);


Nit picking: Could add a test for '0' (string) as well.

gkalpak · 2014-12-18T15:32:38Z

test/ng/filter/limitToSpec.js

+  });
+
+  it('should return an empty string when X = 0', function() {
+    expect(limitTo(str, 0)).toEqual("");


Nit picking: Could add a test for '0' (string) as well.
(I know it was like this before, but single-quotes would also be preferable to double-quotes for consistency.)

gkalpak · 2014-12-18T15:38:07Z

@marcin-wosinek: It is a flake (not related to the build) on SauseLabs only. I restarted the job, but since the tests passed on BrowserStack, it should be OK.

I left two "nit-picky" comments on the tests, but other than that it looks good to me.

_{(There's a typo in the BREAKING CHANGE notice btw: behavoir --> behavio[u]r)}

gkalpak · 2014-12-18T21:01:54Z

LGTM

BREAKING CHANGE: limitTo changed behavior when limit value is invalid. Instead of returning empty object/array it returns unchanged input. Closes #10484

googlebot added the cla: no label Dec 17, 2014

marcin-wosinek force-pushed the marcin-wosinek:master branch from cc70067 to c09dea9 Dec 17, 2014

googlebot added cla: yes and removed cla: no labels Dec 17, 2014

gkalpak reviewed Dec 18, 2014
View changes

marcin-wosinek force-pushed the marcin-wosinek:master branch from c09dea9 to 3c0d8e4 Dec 18, 2014

marcin-wosinek force-pushed the marcin-wosinek:master branch 2 times, most recently from 7d48430 to f1a6390 Dec 18, 2014

gkalpak reviewed Dec 18, 2014
View changes

marcin-wosinek force-pushed the marcin-wosinek:master branch 2 times, most recently from d2e50bd to b66a1fe Dec 18, 2014

marcin-wosinek force-pushed the marcin-wosinek:master branch from b66a1fe to a9ba807 Dec 18, 2014

feat(limitTo): ignore limit when invalid

Loading status checks…

ea5085c

BREAKING CHANGE: limitTo changed behavior when limit value is invalid. Instead of returning empty object/array it returns unchanged input. Closes #10484

marcin-wosinek force-pushed the marcin-wosinek:master branch from a9ba807 to ea5085c Dec 19, 2014

gkalpak mentioned this pull request Dec 20, 2014

refactor(limitTo): no need for all those checks if we use slice #10537

Closed

petebacondarwin closed this in a3c3bf3 Dec 21, 2014

marcin-wosinek mentioned this pull request Dec 21, 2014

limitTo: Ignore limit when undefined #10484

Closed

angular / angular.js

feat(limitTo): ignore limit when undefined #10510

feat(limitTo): ignore limit when undefined #10510

marcin-wosinek commented Dec 17, 2014

googlebot commented Dec 17, 2014

googlebot commented Dec 17, 2014

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gkalpak commented Dec 18, 2014

marcin-wosinek commented Dec 18, 2014

marcin-wosinek commented Dec 18, 2014

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gkalpak commented Dec 18, 2014

gkalpak commented Dec 18, 2014

angular / angular.js

feat(limitTo): ignore limit when undefined #10510

feat(limitTo): ignore limit when undefined #10510

Conversation

marcin-wosinek commented Dec 17, 2014

googlebot commented Dec 17, 2014

googlebot commented Dec 17, 2014

This comment has been minimized.

gkalpak Dec 18, 2014 Member

This comment has been minimized.

gkalpak Dec 18, 2014 Member

This comment has been minimized.

gkalpak Dec 18, 2014 Member

This comment has been minimized.

gkalpak Dec 18, 2014 Member

gkalpak commented Dec 18, 2014

marcin-wosinek commented Dec 18, 2014

marcin-wosinek commented Dec 18, 2014

This comment has been minimized.

gkalpak Dec 18, 2014 Member

This comment has been minimized.

gkalpak Dec 18, 2014 Member

This comment has been minimized.

marcin-wosinek Dec 18, 2014 Author Contributor

gkalpak commented Dec 18, 2014

gkalpak commented Dec 18, 2014

gkalpak Dec 18, 2014
Member

gkalpak Dec 18, 2014
Member

gkalpak Dec 18, 2014
Member

gkalpak Dec 18, 2014
Member

gkalpak Dec 18, 2014
Member

gkalpak Dec 18, 2014
Member

marcin-wosinek Dec 18, 2014
Author Contributor