Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(limitTo): ignore limit when undefined #10510
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
I have left a couple of minor comments inline.
Additionally, I believe a little refactoring is in place: it would be better (i.e. more maintainable/performant) to do the
But "functionality-wise" it should be OK.
BTW, the commit message and breaking change notice are slightly inaccurate: It is not only
@marcin-wosinek: It is a flake (not related to the build) on SauseLabs only. I restarted the job, but since the tests passed on BrowserStack, it should be OK.
I left two "nit-picky" comments on the tests, but other than that it looks good to me.
(There's a typo in the BREAKING CHANGE notice btw: