Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfeat($http): provide a config object as an argument to header functions #10622
Conversation
googlebot
added
the
cla: yes
label
Jan 2, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fundon
commented
Jan 5, 2015
|
+1, Nice! Please merge! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pkozlowski-opensource
Jan 9, 2015
Member
@caitp / @petebacondarwin / @lgalfaso (or anyone else!) - would you guys mind reviewing this one - it is pretty minimal
|
@caitp / @petebacondarwin / @lgalfaso (or anyone else!) - would you guys mind reviewing this one - it is pretty minimal |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
taking a quick gander |
caitp
reviewed
Jan 9, 2015
test/ng/httpSpec.js
| expect(config.bar).toBeUndefined(); | ||
| }); | ||
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pkozlowski-opensource
Jan 9, 2015
Member
@caitp it is tested as otherwise a mocked request would fail, no?
pkozlowski-opensource
Jan 9, 2015
Member
@caitp it is tested as otherwise a mocked request would fail, no?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
caitp
Jan 9, 2015
Contributor
let me check ngMock one sec... But in spite of that, I think you should have a different spec for that, because it's not explicitly testing that, it's explicitly testing that the passed in config object is a shallow copy
caitp
Jan 9, 2015
Contributor
let me check ngMock one sec... But in spite of that, I think you should have a different spec for that, because it's not explicitly testing that, it's explicitly testing that the passed in config object is a shallow copy
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pkozlowski-opensource
Jan 9, 2015
Member
Yep, I thought of splitting it into 2 separate specs when I saw your comment. Will create 2 separate specs.
pkozlowski-opensource
Jan 9, 2015
Member
Yep, I thought of splitting it into 2 separate specs when I saw your comment. Will create 2 separate specs.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Can you guys triage your own PRs please! |
petebacondarwin
added
branch: 1.4.x
component: $http
type: bug
type: feature
needs: work
frequency: moderate
and removed
type: bug
labels
Jan 15, 2015
petebacondarwin
added this to the 1.4.0-beta.1 / 1.3.10 milestone
Jan 15, 2015
pkozlowski-opensource
self-assigned this
Jan 16, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
Jan 17, 2015
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.
googlebot
commented
Jan 17, 2015
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
googlebot
added
cla: no
and removed
cla: yes
labels
Jan 17, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
googlebot
commented
Jan 17, 2015
|
CLAs look good, thanks! |
googlebot
added
cla: yes
and removed
cla: no
labels
Jan 17, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pkozlowski-opensource
Jan 17, 2015
Member
I've rebased this one and split tests based on the review comments.
@caitp do you want to have another look at this one?
|
I've rebased this one and split tests based on the review comments. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I'll take a look on Monday |
caitp
assigned
caitp
and unassigned
pkozlowski-opensource
Jan 17, 2015
caitp
reviewed
Jan 20, 2015
| $httpBackend.flush(); | ||
| }); | ||
| it('should not allow modifications to a config object in header functions', function() { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
caitp
Jan 20, 2015
Contributor
this will also only "ignore" changes to root properties of the config object, so changes to child object properties won't be ignored :( but I don't think it's worth worrying about it until someone complains
caitp
Jan 20, 2015
Contributor
this will also only "ignore" changes to root properties of the config object, so changes to child object properties won't be ignored :( but I don't think it's worth worrying about it until someone complains
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
pkozlowski-opensource
Jan 20, 2015
Member
yeh... but I agree that we shouldn't worry about it too much right now...
pkozlowski-opensource
Jan 20, 2015
Member
yeh... but I agree that we shouldn't worry about it too much right now...
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
still lgtm |
pkozlowski-opensource commentedJan 2, 2015
This is a cleaned up / alternative version for #7235