New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(limitTo): extend the filter to take a beginning index argument #10899

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@tameraydin
Contributor

tameraydin commented Jan 29, 2015

Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input.

Closes #5355

feat(limitTo): extend the filter to take a beginning index argument
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input.

Closes #5355
@gkalpak

This comment has been minimized.

Show comment
Hide comment
@gkalpak

gkalpak Jan 29, 2015

Member

Now that there is an offset parameter, it might make sense to disallow negative limit, as it leads to weird semantics (and code).

Member

gkalpak commented Jan 29, 2015

Now that there is an offset parameter, it might make sense to disallow negative limit, as it leads to weird semantics (and code).

@gkalpak

This comment has been minimized.

Show comment
Hide comment
@gkalpak

gkalpak Jan 29, 2015

Member

But it is going to be a breaking change :(

Member

gkalpak commented Jan 29, 2015

But it is going to be a breaking change :(

@pkozlowski-opensource

This comment has been minimized.

Show comment
Hide comment
@pkozlowski-opensource

pkozlowski-opensource Jan 29, 2015

Member

This PR seems good after a quick look - that is - it does what it announces. Having said this the resulting API is a bit odd... but I guess this is the best we can do without API breaking changes...

Let's reach out to the community to see what other think...

Member

pkozlowski-opensource commented Jan 29, 2015

This PR seems good after a quick look - that is - it does what it announces. Having said this the resulting API is a bit odd... but I guess this is the best we can do without API breaking changes...

Let's reach out to the community to see what other think...

@revolunet

This comment has been minimized.

Show comment
Hide comment
@revolunet

revolunet Jan 29, 2015

Contributor

very cool thanks

Contributor

revolunet commented Jan 29, 2015

very cool thanks

@pkozlowski-opensource pkozlowski-opensource self-assigned this Jan 29, 2015

netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

feat(limitTo): extend the filter to take a beginning index argument
Extend the limitTo filter to take an optional argument for beginning index.
It provides a slice-alike functionality to manipulate the input.

Closes #5355
Closes #10899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment