feat(limitTo): extend the filter to take a beginning index argument #10899

Closed
wants to merge 1 commit into
from

Projects

None yet

6 participants

@tameraydin
Contributor

Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input.

Closes #5355

@googlebot googlebot added the cla: yes label Jan 29, 2015
@tameraydin tameraydin feat(limitTo): extend the filter to take a beginning index argument
Extend the limitTo filter to take an optional argument for beginning index. It provides a slice-alike functionality to manipulate the input.

Closes #5355
d96c48c
@gkalpak
Member
gkalpak commented Jan 29, 2015

Now that there is an offset parameter, it might make sense to disallow negative limit, as it leads to weird semantics (and code).

@gkalpak
Member
gkalpak commented Jan 29, 2015

But it is going to be a breaking change :(

@pkozlowski-opensource

This PR seems good after a quick look - that is - it does what it announces. Having said this the resulting API is a bit odd... but I guess this is the best we can do without API breaking changes...

Let's reach out to the community to see what other think...

@revolunet
Contributor

very cool thanks

@pkozlowski-opensource pkozlowski-opensource self-assigned this Jan 29, 2015
@pkozlowski-opensource pkozlowski-opensource added a commit that closed this pull request Feb 17, 2015
@tameraydin @pkozlowski-opensource tameraydin + pkozlowski-opensource feat(limitTo): extend the filter to take a beginning index argument
Extend the limitTo filter to take an optional argument for beginning index.
It provides a slice-alike functionality to manipulate the input.

Closes #5355
Closes #10899
aaae3cc
@netman92 netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@tameraydin @netman92 tameraydin + netman92 feat(limitTo): extend the filter to take a beginning index argument
Extend the limitTo filter to take an optional argument for beginning index.
It provides a slice-alike functionality to manipulate the input.

Closes #5355
Closes #10899
2ddb06c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment