New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider.$decorator to angular.Module #11300

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@RodneyEbanks
Contributor

RodneyEbanks commented Mar 11, 2015

Allow for decorators to be added prior to the angular.config process.

Use case: I am working on a project using ui.router and would like to modify the $stateProvide.state service and would like to ensure that my modification will always be applied prior to any angular.config blocks which could contain $stateProvide.state requests.

This would also allow any decorators to be clearly delineated in your code and not lost in a config block.

Add provider.$decorator to angular.Module
Allow for decorators to be added prior to the angular.config process.

Use case: I am working on a project using ui.router and would like to modify the $stateProvide.state service and would like to ensure that my modification will always be applied prior to any angular.config blocks which could contain $stateProvide.state requests.

This would also allow any decorators to be clearly delineated in your code and not lost in a config block.
@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Mar 11, 2015

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented Mar 11, 2015

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label Mar 11, 2015

@RodneyEbanks

This comment has been minimized.

Show comment
Hide comment
@RodneyEbanks

RodneyEbanks Mar 11, 2015

Contributor

CLA Signed - Individual email: github@rodneyebanks.com username: RodneyEbanks.

Contributor

RodneyEbanks commented Mar 11, 2015

CLA Signed - Individual email: github@rodneyebanks.com username: RodneyEbanks.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Mar 11, 2015

CLAs look good, thanks!

googlebot commented Mar 11, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Mar 11, 2015

@lgalfaso

This comment has been minimized.

Show comment
Hide comment
@lgalfaso

lgalfaso Mar 11, 2015

Member

Hi, thanks for the PR.

  • Please fix the style issues
  • A few tests would not hurt :)
Member

lgalfaso commented Mar 11, 2015

Hi, thanks for the PR.

  • Please fix the style issues
  • A few tests would not hurt :)

@RodneyEbanks RodneyEbanks deleted the RodneyEbanks:patch-1 branch Mar 12, 2015

petebacondarwin added a commit that referenced this pull request Mar 17, 2015

netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment