Add provider.$decorator to angular.Module #11300

Closed
wants to merge 5 commits into
from

Projects

None yet

3 participants

@RodneyEbanks
Contributor

Allow for decorators to be added prior to the angular.config process.

Use case: I am working on a project using ui.router and would like to modify the $stateProvide.state service and would like to ensure that my modification will always be applied prior to any angular.config blocks which could contain $stateProvide.state requests.

This would also allow any decorators to be clearly delineated in your code and not lost in a config block.

@RodneyEbanks RodneyEbanks Add provider.$decorator to angular.Module
Allow for decorators to be added prior to the angular.config process.

Use case: I am working on a project using ui.router and would like to modify the $stateProvide.state service and would like to ensure that my modification will always be applied prior to any angular.config blocks which could contain $stateProvide.state requests.

This would also allow any decorators to be clearly delineated in your code and not lost in a config block.
e7ac65b
@googlebot

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label Mar 11, 2015
@RodneyEbanks
Contributor

CLA Signed - Individual email: github@rodneyebanks.com username: RodneyEbanks.

@googlebot

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Mar 11, 2015
@lgalfaso
Member

Hi, thanks for the PR.

  • Please fix the style issues
  • A few tests would not hurt :)
RodneyEbanks added some commits Mar 12, 2015
@RodneyEbanks RodneyEbanks Correct style issue
87af0db
@RodneyEbanks RodneyEbanks Add test for provider.$decorator to angular.Module
a07c1b8
@RodneyEbanks RodneyEbanks Test addition fix
c70d04f
@RodneyEbanks RodneyEbanks Test fix 2
bd9f2f3
@RodneyEbanks RodneyEbanks deleted the unknown repository branch Mar 12, 2015
@netman92 netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@RodneyEbanks @netman92 RodneyEbanks + netman92 feat(angular.Module): add `decorator` method
Closes #11305
Closes #11300
083d6f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment