New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng, decorator): Add decorator Method (provider.$decorator) to angular.Module #11305

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@RodneyEbanks
Contributor

RodneyEbanks commented Mar 12, 2015

Allow for decorators to be added prior to the angular.config process.

Use case: I am working on a project using ui.router and would like to modify the $stateProvide.state service and would like to ensure that my modification will always be applied prior to any angular.config blocks which could contain $stateProvide.state requests.

This would also allow any decorators to be clearly delineated in your code and not lost in a config block.

Replaces Pull Request #11300

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Mar 12, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot commented Mar 12, 2015

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no label Mar 12, 2015

@RodneyEbanks

This comment has been minimized.

Show comment
Hide comment
@RodneyEbanks

RodneyEbanks Mar 12, 2015

Contributor

I did author these changes.

CLA email updated.

Contributor

RodneyEbanks commented Mar 12, 2015

I did author these changes.

CLA email updated.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Mar 13, 2015

CLAs look good, thanks!

googlebot commented Mar 13, 2015

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Mar 13, 2015

@RodneyEbanks RodneyEbanks changed the title from Add provider.$decorator to angular.Module to feat(ng, decorator): Add decorator Method (provider.$decorator) to angular.Module Mar 16, 2015

netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment