Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix passing eventHandlers when passThrough #14471

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@andreyjkee
Copy link
Contributor

andreyjkee commented Apr 20, 2016

Bug fix
This commit fix passing eventHandlers and uploadEventHandlers when using angular.mock

Need to fix function arguments in tests: angular.js/test/ngMock/angular-mocksSpec.js

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 20, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
1 similar comment
@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 20, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no label Apr 20, 2016

@andreyjkee

This comment has been minimized.

Copy link
Contributor Author

andreyjkee commented Apr 20, 2016

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 20, 2016

CLAs look good, thanks!

1 similar comment
@googlebot

This comment has been minimized.

Copy link

googlebot commented Apr 20, 2016

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 20, 2016

@Narretz

This comment has been minimized.

Copy link
Contributor

Narretz commented Apr 20, 2016

Thanks for the PR! Good catch. Can you please update these 2 tests, too?

it('should delegate requests to the real backend when passThrough is invoked', function() {
hb.when('GET', /\/passThrough\/.*/).passThrough();
hb('GET', '/passThrough/23', null, callback, {}, null, true, 'blob');
expect(realHttpBackend).toHaveBeenCalledOnceWith(
'GET', '/passThrough/23', null, callback, {}, null, true, 'blob');
});
it('should be able to override a respond definition with passThrough', function() {
var definition = hb.when('GET', /\/passThrough\/.*/).respond('override me');
definition.passThrough();
hb('GET', '/passThrough/23', null, callback, {}, null, true);
expect(realHttpBackend).toHaveBeenCalledOnceWith(
'GET', '/passThrough/23', null, callback, {}, null, true, undefined);
});

@Narretz Narretz added this to the 1.5.6 milestone Apr 20, 2016

@andreyjkee

This comment has been minimized.

Copy link
Contributor Author

andreyjkee commented Apr 20, 2016

yes, tests updated

@Narretz Narretz closed this in 253cb8d Apr 21, 2016

Narretz added a commit that referenced this pull request Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.