From 8b3a2cfd7e2947cf01a8e1512ddb157f5437b852 Mon Sep 17 00:00:00 2001 From: Thomas Kowalski Date: Sun, 15 May 2016 13:13:24 +0200 Subject: [PATCH 1/2] Update component-router.ngdoc the id was missing, heroId was unused --- docs/content/guide/component-router.ngdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/guide/component-router.ngdoc b/docs/content/guide/component-router.ngdoc index bb6bba53ae1f..dd8bd0f2f1b1 100644 --- a/docs/content/guide/component-router.ngdoc +++ b/docs/content/guide/component-router.ngdoc @@ -855,7 +855,7 @@ function HeroDetailComponent(heroService) { ... this.gotoHeroes = function() { var heroId = this.hero && this.hero.id; - this.$router.navigate(['HeroList']); + this.$router.navigate(['HeroList', {id: heroId}]); }; ``` From cc0c4651fbef7968040f613f39fa5d094c3bcdbf Mon Sep 17 00:00:00 2001 From: Thomas Kowalski Date: Tue, 17 May 2016 09:22:22 +0200 Subject: [PATCH 2/2] Update component-router.ngdoc Remove 'var heroId = ...' as suggested by @gkalpak --- docs/content/guide/component-router.ngdoc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/content/guide/component-router.ngdoc b/docs/content/guide/component-router.ngdoc index dd8bd0f2f1b1..b52599f0ee46 100644 --- a/docs/content/guide/component-router.ngdoc +++ b/docs/content/guide/component-router.ngdoc @@ -854,8 +854,7 @@ Router itself, which was made available by the binding in the **Component Defini function HeroDetailComponent(heroService) { ... this.gotoHeroes = function() { - var heroId = this.hero && this.hero.id; - this.$router.navigate(['HeroList', {id: heroId}]); + this.$router.navigate(['HeroList']); }; ```