Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove expression sandbox #15094
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
The angular expression parsers attempts to sandbox the expressions to prevent unrestricted access to the global context.
What is the new behavior (if this is a feature change)?
The sandbox is removed, as it was not a real security feature.
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Once it has a proper commit message and a couple of unused vars at the top of the file are removed (I only found some cached methods, that's all) I think it's ready to land. Performance improvements can be addressed in subsequent PRs/commits, I like that this one mostly cleanly removes stuff.
Other than that, LGTM.