This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(errorHandlingConfig): add test for errorHandlingConfig() to be i… #15770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-amr
force-pushed
the
test_error_handling
branch
from
21522fe to
b80da97
Compare
m-amr
added a commit
to m-amr/angular.js
that referenced
this pull request
Mar 2, 2017
…ndependent of minErr Closes angular#15770
gkalpak
suggested changes
Mar 3, 2017
test/AngularSpec.js
Outdated
| expect(errorHandlingConfig().objectMaxDepth).toBe(5); | ||
| }); | ||
|
|
||
| it('should set objectMaxDepthx', function() { |
Member
There was a problem hiding this comment.
objectMaxDepthx --> objectMaxDepth
test/AngularSpec.js
Outdated
|
|
||
| it('should set objectMaxDepthx', function() { | ||
| errorHandlingConfig({objectMaxDepth: 3}); | ||
| expect(errorHandlingConfig()).toEqual({objectMaxDepth: 3}); |
Member
There was a problem hiding this comment.
To make this test more robust, use expect(errorHandlingConfig().objectMaxDepth).toBe(3).
So, if we introduce more properties in the future, it won't break.
test/AngularSpec.js
Outdated
| expect(errorHandlingConfig().objectMaxDepth).toBe(originalObjectMaxDepthInErrorMessage); | ||
| }); | ||
|
|
||
| they('should set objectMaxDepth to NAN when $prop is supplied', |
m-amr
force-pushed
the
test_error_handling
branch
from
b80da97 to
ed6269a
Compare
m-amr
added a commit
to m-amr/angular.js
that referenced
this pull request
Mar 3, 2017
…ndependent of minErr Closes angular#15770
Contributor
Author
|
@gkalpak |
gkalpak
approved these changes
Mar 3, 2017
Member
gkalpak
left a comment
gkalpak
left a comment
There was a problem hiding this comment.
One minor nit. LGTM otherwise 😃
test/AngularSpec.js
Outdated
| expect(errorHandlingConfig().objectMaxDepth).toBe(originalObjectMaxDepthInErrorMessage); | ||
| }); | ||
|
|
||
| they('should set objectMaxDepth to Nan when $prop is supplied', |
Member
There was a problem hiding this comment.
I just realized I accidentally wrote Nan in my previous comment. I meant NaN 😁
m-amr
force-pushed
the
test_error_handling
branch
from
ed6269a to
eab5ec0
Compare
Contributor
Author
|
@gkalpak |
…ndependent of minErr Closes angular#15770
gkalpak
pushed a commit
that referenced
this pull request
Mar 4, 2017
…ependent of `minErr`) Closes #15770
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
…ependent of `minErr`) Closes angular#15770
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndependent of minErr
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
test
What is the current behavior? (You can also link to an open issue here)
There is no test for errorHandlingConfig
What is the new behavior (if this is a feature change)?
Add tests to errorHandlingConfig independent of minErr tests
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information:
These tests was added in #15707 , but it looks like there are some problems in the PR, so i have added the missing tests in this PR.