New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing decoration of $q service functions #5999

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@egobrain

egobrain commented Jan 27, 2014

Fixes #5998 issue

@mary-poppins

This comment has been minimized.

mary-poppins commented Jan 28, 2014

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins

This comment has been minimized.

mary-poppins commented Jan 28, 2014

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@egobrain

This comment has been minimized.

egobrain commented Feb 17, 2014

Any news about this issue?

@spalger

This comment has been minimized.

spalger commented Feb 19, 2014

👍

@lgalfaso

This comment has been minimized.

Member

lgalfaso commented Mar 3, 2014

This should be possible when 1.3 arrives with a prototype based $q

@btford btford modified the milestones: 1.3.0, Backlog Mar 17, 2014

@wejendorp

This comment has been minimized.

wejendorp commented May 26, 2014

@lgalfaso where do you find this?
Either way, 👍 on this!

@btford btford removed the gh: PR label Aug 20, 2014

@caitp caitp force-pushed the angular:master branch from 591bac5 to d713ad1 Aug 22, 2014

@tbosch tbosch force-pushed the angular:master branch from 6c27b89 to 271572c Aug 30, 2014

@tbosch tbosch force-pushed the angular:master branch from a3d7934 to 1418383 Sep 10, 2014

@petebacondarwin petebacondarwin force-pushed the angular:master branch from 02dc2aa to fd2d6c0 Sep 16, 2014

@jeffbcross jeffbcross force-pushed the angular:master branch 2 times, most recently from cad9560 to f294244 Sep 27, 2014

@btford btford force-pushed the angular:master branch from 9011a65 to 46db47b Oct 6, 2014

@jeffbcross jeffbcross force-pushed the angular:master branch 4 times, most recently from e8dc429 to e83fab9 Oct 8, 2014

@petebacondarwin petebacondarwin force-pushed the angular:master branch from 4dd5a20 to 998c61c Oct 19, 2014

@lgalfaso

This comment has been minimized.

Member

lgalfaso commented Mar 11, 2015

This issue is no longer relevant, as it is possible to access the prototype and add extend it in any way needed using Object.getPrototypeOf. In the case I am missing something, feel free to comment/reopen this issue

@lgalfaso lgalfaso closed this Mar 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment