Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove $http.patch reference #9180

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@alexandremello
Copy link

commented Sep 19, 2014

There is no $http.patch method. Removed references.

Remove $http.patch reference
There is no $http.patch method. Removed references.
@caitp

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2014

.....? the definitiion of the patch method is literally right below some of the removed code

@mary-poppins

This comment has been minimized.

Copy link

commented Sep 19, 2014

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@mary-poppins mary-poppins added cla: no and removed cla: yes labels Sep 19, 2014

@gkalpak

This comment has been minimized.

Copy link
Member

commented Sep 19, 2014

I think there is a little confusion going on:

In 1.3.x there is indeed a patch() shortcut and the docs are correct.
In 1.2.x there isn't a patch() method, but there is still a little mention in the docs.

We should probably add the patch() shortcut (and fix the docs to properly mention it) instead of removing it from the docs.

The confusion arises from the fact that while on the 1.2.25 docs, when you press the View Source or Improve this doc buttons, you are taken to the corresponding source on master (not on the 1.2.25 version). I don't know if this is intended, but it sure is confusing.

@caitp

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2014

I think the right thing to do is close this PR and submit a second PR to fix 1.2.25 (to re-add the patch method). We might need to re-add it to ngMock, because I recall it was missing from there before too.

How does that sound to you?

@jeffbcross jeffbcross force-pushed the angular:master branch from dbbabb9 to 27d1234 Sep 27, 2014

gkalpak added a commit to gkalpak/angular.js that referenced this pull request Sep 28, 2014

fix($http): add missing shortcut methods and missing docs
There was some inconsistency in version 1.2.25 regarding the definition
and documentation of shortcut methods in `ng.$http` and
`ngMock[E2E].$httpBackend`. Some methods didn't exist (although documented
as existing), whereas some methods did exist, but wheren't documented.
This commit fixes the above errors and adds tests to verify the existence
of all shortcut methods.
More specificcally, the following issues were addressed:
`ng.$http`: Add the missing `patch()` shortcut method and related docs.
`ng.$http` spec: Add test to verify the existence and functionality of the
`patch()` shortcut method.
`ngMock[E2E].$httpBackend`: Add docs for the (existing) `whenPATCH()`
shortcut method, add the missing `expectHEAD()`/`whenHEAD()` shortcut
methods, fix grammatical errors.
`ngMock[E2E].$httpBackend` spec: Add test to verify the existence of shortcut
methods for all HTTP verbs.

Closes angular#9180
@gkalpak

This comment has been minimized.

Copy link
Member

commented Sep 28, 2014

@caitp: I have prepared a patch for fixing missing shortcut methods and related documentation in v1.2.25.
Should I submit the PR against master or what ?

@caitp

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2014

@gkalpak v1.2.x is missing the patch method and documentation for the patch method (although it does have a link to its docs for the patch method). If you wrote the PR against v1.2.x, then feel free to submit the PR against v1.2.x

@jeffbcross jeffbcross force-pushed the angular:master branch from cad9560 to f294244 Oct 2, 2014

@btford btford force-pushed the angular:master branch from 9011a65 to 46db47b Oct 6, 2014

@jeffbcross jeffbcross force-pushed the angular:master branch 2 times, most recently from abdaab7 to 30996f8 Oct 8, 2014

petebacondarwin added a commit that referenced this pull request Oct 9, 2014

fix($http): add missing shortcut methods and missing docs
There was some inconsistency in version 1.2.25 regarding the definition
and documentation of shortcut methods in `ng.$http` and
`ngMock[E2E].$httpBackend`. Some methods didn't exist (although documented
as existing), whereas some methods did exist, but wheren't documented.
This commit fixes the above errors and adds tests to verify the existence
of all shortcut methods.
More specificcally, the following issues were addressed:
`ng.$http`: Add the missing `patch()` shortcut method and related docs.
`ng.$http` spec: Add test to verify the existence and functionality of the
`patch()` shortcut method.
`ngMock[E2E].$httpBackend`: Add docs for the (existing) `whenPATCH()`
shortcut method, add the missing `expectHEAD()`/`whenHEAD()` shortcut
methods, fix grammatical errors.
`ngMock[E2E].$httpBackend` spec: Add test to verify the existence of shortcut
methods for all HTTP verbs.

Closes #9180
Closes #9321
@petebacondarwin

This comment has been minimized.

Copy link
Member

commented Oct 9, 2014

Landed ec4fe1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.