New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat($anchorScroll): allow scrolling to a specified element #9596

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@gkalpak
Member

gkalpak commented Oct 13, 2014

Add an optional argument to $anchorScroll() to enable scrolling to an anchor element different than that related to the current value of $location.hash(). If the argument is omitted, the value of $location.hash() will be used instead.

Closes #4568

@mary-poppins mary-poppins added cla: yes and removed cla: no labels Oct 13, 2014

@tbosch tbosch self-assigned this Oct 13, 2014

@tbosch tbosch modified the milestones: low, Backlog Oct 13, 2014

@tbosch tbosch removed their assignment Oct 13, 2014

@gkalpak

This comment has been minimized.

Show comment
Hide comment
@gkalpak

gkalpak Nov 10, 2014

Member

Small and safe little feature, with docs and tests - what's not to love about this PR (even Travis likes it) ;)

Member

gkalpak commented Nov 10, 2014

Small and safe little feature, with docs and tests - what's not to love about this PR (even Travis likes it) ;)

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 21, 2014

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented Nov 21, 2014

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added cla: no and removed cla: yes labels Nov 21, 2014

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Nov 23, 2014

CLAs look good, thanks!

googlebot commented Nov 23, 2014

CLAs look good, thanks!

@petebacondarwin

This comment has been minimized.

Show comment
Hide comment
@petebacondarwin

petebacondarwin Apr 2, 2015

Member

I would make the commit title: feat($anchorScroll): allow scrolling to a specified element

Member

petebacondarwin commented Apr 2, 2015

I would make the commit title: feat($anchorScroll): allow scrolling to a specified element

@petebacondarwin

This comment has been minimized.

Show comment
Hide comment
@petebacondarwin

petebacondarwin Apr 2, 2015

Member

If you could deal with the small comments above then LGTM

Member

petebacondarwin commented Apr 2, 2015

If you could deal with the small comments above then LGTM

@gkalpak gkalpak changed the title from feat($anchorScroll): add support for scrolling independently of `$location.hash()` to feat($anchorScroll): allow scrolling to a specified element Apr 2, 2015

@petebacondarwin

This comment has been minimized.

Show comment
Hide comment
@petebacondarwin
Member

petebacondarwin commented Apr 2, 2015

LGTM

feat($anchorScroll): allow scrolling to a specified element
Add an optional argument to `$anchorScroll()` to enable scrolling to an
anchor element different than that related to the current value of
`$location.hash()`. If the argument is omitted or is not a string,
the value of `$location.hash()` will be used instead.

Closes #4568

@gkalpak gkalpak closed this in 731c8b5 Apr 2, 2015

@gkalpak gkalpak deleted the gkalpak:$anchorScroll-explicit-hash branch Apr 2, 2015

netman92 added a commit to netman92/angular.js that referenced this pull request Aug 8, 2015

feat($anchorScroll): allow scrolling to a specified element
Add an optional argument to `$anchorScroll()` to enable scrolling to an
anchor element different than that related to the current value of
`$location.hash()`. If the argument is omitted or is not a string,
the value of `$location.hash()` will be used instead.

Closes #4568
Closes #9596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment