Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix($rootScope): remove history event handler when app is torn down #9905
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.
Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.
If you signed the CLA as a corporation, please let us know the company's name.
Thanks a bunch!
PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
I agree with @caitp that the shutdown idea is more complex than this patch (with all that this implies). The only thing in favor is that it takes care of cleaning up
referenced this pull request
Mar 8, 2015
How about putting the
For example, if
I can move the removal method call to where you suggest, but I think we should still keep