Skip to content
Permalink
Browse files

fix(compiler): don’t type check property access of literal maps (#19301)

This was the behavior in Ng4, so we put the stricter
check behind the `fullTemplateTypeCheck` flag.
PR Close #19301
  • Loading branch information...
tbosch authored and IgorMinar committed Sep 20, 2017
1 parent 45747ed commit 04997c84189b01425ddc3093986e9a9c80c31456
@@ -141,6 +141,12 @@ describe('ng type checker', () => {
'<div>{{"hello" | aPipe}}</div>',
`Argument of type '"hello"' is not assignable to parameter of type 'number'.`, '0:5');
});
it('should report an index into a map expression', () => {
rejectOnlyWithFullTemplateTypeCheck(
'<div>{{ {a: 1}[name] }}</div>',
`Element implicitly has an 'any' type because type '{ a: number; }' has no index signature.`,
'0:5');
});
it('should report an invalid property on an exportAs directive', () => {
rejectOnlyWithFullTemplateTypeCheck(
'<div aDir #aDir="aDir">{{aDir.fname}}</div>',
@@ -251,26 +251,31 @@ class ViewBuilder implements TemplateAstVisitor, LocalResolver {
context: expression.context,
value: convertPropertyBindingBuiltins(
{
createLiteralArrayConverter: (argCount: number) => (args: o.Expression[]) =>
o.literalArr(args),
createLiteralMapConverter: (keys: {key: string, quoted: boolean}[]) =>
(values: o.Expression[]) => {
const entries = keys.map((k, i) => ({
key: k.key,
value: values[i],
quoted: k.quoted,
}));
return o.literalMap(entries);
},
createLiteralArrayConverter: (argCount: number) => (args: o.Expression[]) => {
const arr = o.literalArr(args);
// Note: The old view compiler used to use an `any` type
// for arrays.
return this.options.fullTemplateTypeCheck ? arr : arr.cast(o.DYNAMIC_TYPE);
},
createLiteralMapConverter:
(keys: {key: string, quoted: boolean}[]) => (values: o.Expression[]) => {
const entries = keys.map((k, i) => ({
key: k.key,
value: values[i],
quoted: k.quoted,
}));
const map = o.literalMap(entries);
// Note: The old view compiler used to use an `any` type
// for maps.
return this.options.fullTemplateTypeCheck ? map : map.cast(o.DYNAMIC_TYPE);
},
createPipeConverter: (name: string, argCount: number) => (args: o.Expression[]) => {
// Note: The old view compiler used to use an `any` type
// for pipe calls.
// We keep this behaivor behind a flag for now.
if (this.options.fullTemplateTypeCheck) {
return o.variable(this.pipeOutputVar(name)).callMethod('transform', args);
} else {
return o.variable(this.getOutputVar(o.BuiltinTypeName.Dynamic));
}
// for pipes.
const pipeExpr = this.options.fullTemplateTypeCheck ?
o.variable(this.pipeOutputVar(name)) :
o.variable(this.getOutputVar(o.BuiltinTypeName.Dynamic));
return pipeExpr.callMethod('transform', args);
},
},
expression.value)

0 comments on commit 04997c8

Please sign in to comment.
You can’t perform that action at this time.