Skip to content
Permalink
Browse files

fix(common): properly check NaN value (#22305)

closes #15721

PR Close #22305
  • Loading branch information...
trotyl authored and benlesh committed Apr 16, 2019
1 parent c3c0df9 commit 3f6bf6dfd166b994f6e99dc99f15a34cf833f8cf
Showing with 14 additions and 2 deletions.
  1. +2 −2 packages/common/src/pipes/async_pipe.ts
  2. +12 −0 packages/common/test/pipes/async_pipe_spec.ts
@@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/

import {ChangeDetectorRef, EventEmitter, Injectable, OnDestroy, Pipe, PipeTransform, WrappedValue, ɵisObservable, ɵisPromise} from '@angular/core';
import {ChangeDetectorRef, EventEmitter, Injectable, OnDestroy, Pipe, PipeTransform, WrappedValue, ɵisObservable, ɵisPromise, ɵlooseIdentical} from '@angular/core';
import {Observable, SubscriptionLike} from 'rxjs';
import {invalidPipeArgumentError} from './invalid_pipe_argument_error';

@@ -103,7 +103,7 @@ export class AsyncPipe implements OnDestroy, PipeTransform {
return this.transform(obj as any);
}

if (this._latestValue === this._latestReturnedValue) {
if (ɵlooseIdentical(this._latestValue, this._latestReturnedValue)) {
return this._latestReturnedValue;
}

@@ -82,6 +82,18 @@ import {SpyChangeDetectorRef} from '../spies';
async.done();
}, 10);
}));

it('should return unwrapped value for unchanged NaN', () => {
const emitter = new EventEmitter<any>();
emitter.emit(null);
pipe.transform(emitter);
emitter.next(NaN);
const firstResult = pipe.transform(emitter);
const secondResult = pipe.transform(emitter);
expect(firstResult instanceof WrappedValue).toBe(true);
expect((firstResult as WrappedValue).wrapped).toBeNaN();
expect(secondResult).toBeNaN();
});
});

describe('ngOnDestroy', () => {

0 comments on commit 3f6bf6d

Please sign in to comment.
You can’t perform that action at this time.