Please sign in to comment.
fix(ivy): ngtsc throws if "flatModuleOutFile" is set to null (#32235)
In ngc is was valid to set the "flatModuleOutFile" option to "null". This is sometimes necessary if a tsconfig extends from another one but the "fatModuleOutFile" option needs to be unset (note that "undefined" does not exist as value in JSON) Now if ngtsc is used to compile the project, ngtsc will fail with an error because it tries to do string manipulation on the "flatModuleOutFile". This happens because ngtsc only skips flat module indices if the option is set to "undefined". Since this is not compatible with what was supported in ngc and such exceptions should be avoided, the flat module check is now aligned with ngc. ``` TypeError: Cannot read property 'replace' of null at Object.normalizeSeparators (/home/circleci/project/node_modules/@angular/compiler-cli/src/ngtsc/util/src/path.js:35:21) at new NgtscProgram (/home/circleci/project/node_modules/@angular/compiler-cli/src/ngtsc/program.js:126:52) ``` Additionally setting the `flatModuleOutFile` option to an empty string currently results in unexpected behavior. No errors is thrown, but the flat module index file will be `.ts` (no file name; just extension). This is now also fixed by treating an empty string similarly to `null`. PR Close #32235
- Loading branch information...
Showing with 32 additions and 2 deletions.