Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(core): do not clear element content when using shadow dom
- Loading branch information
1 parent
05e3e4d
commit 525ca3e
Showing
6 changed files
with
199 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,168 @@ | ||
/** | ||
* @license | ||
* Copyright Google Inc. All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {Component, ComponentFactoryResolver, EventEmitter, Injector, Input, NgModule, Output, ViewEncapsulation, destroyPlatform} from '@angular/core'; | ||
import {BrowserModule} from '@angular/platform-browser'; | ||
import {platformBrowserDynamic} from '@angular/platform-browser-dynamic'; | ||
import {Subject} from 'rxjs'; | ||
|
||
import {NgElement, NgElementConstructor, createCustomElement} from '../src/create-custom-element'; | ||
import {NgElementStrategy, NgElementStrategyEvent, NgElementStrategyFactory} from '../src/element-strategy'; | ||
|
||
type WithFooBar = { | ||
fooFoo: string, | ||
barBar: string | ||
}; | ||
|
||
if (typeof customElements !== 'undefined') { | ||
describe('slots', () => { | ||
let testContainer: HTMLDivElement; | ||
|
||
beforeAll(done => { | ||
testContainer = document.createElement('div'); | ||
document.body.appendChild(testContainer); | ||
destroyPlatform(); | ||
platformBrowserDynamic() | ||
.bootstrapModule(TestModule) | ||
.then(ref => { | ||
const injector = ref.injector; | ||
const cfr: ComponentFactoryResolver = injector.get(ComponentFactoryResolver); | ||
|
||
testElements.forEach(comp => { | ||
const compFactory = cfr.resolveComponentFactory(comp); | ||
customElements.define(compFactory.selector, createCustomElement(comp, {injector})); | ||
}); | ||
}) | ||
.then(done, done.fail); | ||
}); | ||
|
||
afterAll(() => { | ||
destroyPlatform(); | ||
testContainer.remove(); | ||
(testContainer as any) = null; | ||
}); | ||
|
||
it('should use slots to project content', () => { | ||
const tpl = `<default-slot-el><span class="projected"></span></default-slot-el>` | ||
testContainer.innerHTML = tpl; | ||
const testEl = testContainer.querySelector('default-slot-el') !; | ||
const content = testContainer.querySelector('span.projected') !; | ||
const slot = testEl.shadowRoot !.querySelector('slot') !; | ||
const assignedNodes = slot.assignedNodes(); | ||
expect(assignedNodes[0]).toEqual(content); | ||
}); | ||
|
||
it('should use a named slot to project content', () => { | ||
const tpl = `<named-slot-el><span class="projected" slot="header"></span></named-slot-el>` | ||
testContainer.innerHTML = tpl; | ||
const testEl = testContainer.querySelector('named-slot-el') !; | ||
const content = testContainer.querySelector('span.projected') !; | ||
const slot = testEl.shadowRoot !.querySelector('slot[name=header]') as HTMLSlotElement; | ||
const assignedNodes = slot.assignedNodes(); | ||
expect(assignedNodes[0]).toEqual(content); | ||
}); | ||
|
||
it('should use named slots to project content', () => { | ||
const tpl = ` | ||
<named-slots-el> | ||
<span class="projected-header" slot="header"></span> | ||
<span class="projected-body" slot="body"></span> | ||
</named-slots-el>` | ||
testContainer.innerHTML = tpl; | ||
const testEl = testContainer.querySelector('named-slots-el') !; | ||
const headerContent = testContainer.querySelector('span.projected-header') !; | ||
const bodyContent = testContainer.querySelector('span.projected-body') !; | ||
const headerSlot = testEl.shadowRoot !.querySelector('slot[name=header]') as HTMLSlotElement; | ||
const bodySlot = testEl.shadowRoot !.querySelector('slot[name=body]') as HTMLSlotElement; | ||
|
||
expect(headerContent.assignedSlot).toEqual(headerSlot); | ||
expect(bodyContent.assignedSlot).toEqual(bodySlot); | ||
}); | ||
|
||
it('should listen to slotchange events', (done) => { | ||
const templateEl = document.createElement('template'); | ||
const tpl = ` | ||
<slot-events-el> | ||
<span class="projected">Content</span> | ||
</slot-events-el>` | ||
templateEl.innerHTML = tpl; | ||
const template = templateEl.content.cloneNode(true) as DocumentFragment; | ||
const testEl = template.querySelector('slot-events-el') !as NgElement & SlotEventsComponent; | ||
const content = template.querySelector('span.projected'); | ||
testEl.addEventListener('slotEventsChange', e => { | ||
expect(testEl.slotEvents.length).toEqual(1); | ||
done(); | ||
}); | ||
testContainer.appendChild(template); | ||
expect(testEl.slotEvents.length).toEqual(0); | ||
}); | ||
}); | ||
} | ||
|
||
// Helpers | ||
@Component({ | ||
selector: 'default-slot-el', | ||
template: '<div class="slotparent"><slot></slot></div>', | ||
encapsulation: ViewEncapsulation.ShadowDom | ||
}) | ||
class DefaultSlotComponent { | ||
constructor() {} | ||
} | ||
|
||
@Component({ | ||
selector: 'named-slot-el', | ||
template: '<div class="slotparent"><slot name="header"></slot></div>', | ||
encapsulation: ViewEncapsulation.ShadowDom | ||
}) | ||
class NamedSlotComponent { | ||
constructor() {} | ||
} | ||
|
||
@Component({ | ||
selector: 'named-slots-el', | ||
template: '<div class="slotparent"><slot name="header"></slot><slot name="body"></slot></div>', | ||
encapsulation: ViewEncapsulation.ShadowDom | ||
}) | ||
class NamedSlotsComponent { | ||
constructor() {} | ||
} | ||
|
||
@Component({ | ||
selector: 'default-slots-el', | ||
template: '<div class="slotparent"><slot name="header"></slot><slot name="body"></slot></div>', | ||
encapsulation: ViewEncapsulation.ShadowDom | ||
}) | ||
class DefaultSlotsComponent { | ||
constructor() {} | ||
} | ||
|
||
@Component({ | ||
selector: 'slot-events-el', | ||
template: '<slot (slotchange)="onSlotChange($event)"></slot>', | ||
encapsulation: ViewEncapsulation.ShadowDom | ||
}) | ||
class SlotEventsComponent { | ||
@Input() slotEvents: Event[] = []; | ||
@Output() slotEventsChange = new EventEmitter(); | ||
constructor() {} | ||
onSlotChange(event: Event) { | ||
this.slotEvents.push(event); | ||
this.slotEventsChange.emit(event); | ||
} | ||
} | ||
|
||
const testElements = | ||
[ | ||
DefaultSlotComponent, NamedSlotComponent, NamedSlotsComponent, DefaultSlotsComponent, | ||
SlotEventsComponent | ||
] | ||
|
||
@NgModule({imports: [BrowserModule], declarations: testElements, entryComponents: testElements}) | ||
class TestModule { | ||
ngDoBootstrap() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters