Skip to content
Permalink
Browse files

fix(bazel): reenable template type checking in ng_module (#34144)

due to an unfortunate condition in https://github.com/angular/angular/blob/168abc6d6f52713383411b14980e104c99bfeef5/packages/compiler-cli/src/ngtsc/program.ts#L430-L434 the typechecking has been disabled when running under bazel + ivy.

As far as I can tell the ivyTemplateTypeCheck flag is now obsolete, so removing this
code from ng_module.bzl is desirable. I'll send a separate PR to remove the flag completely.

PR Close #34144
  • Loading branch information
IgorMinar authored and mhevery committed Nov 29, 2019
1 parent 0d102bb commit 572e731b63ffaf332b2cc4eb1619b193667545c1
Showing with 0 additions and 3 deletions.
  1. +0 −3 packages/bazel/src/ng_module.bzl
@@ -305,9 +305,6 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
"enableSummariesForJit": is_legacy_ngc,
"enableIvy": is_ivy_enabled(ctx),
"fullTemplateTypeCheck": ctx.attr.type_check,
# TODO(alxhub/arick): template type-checking for Ivy needs to be tested in g3 before it can
# be enabled here.
"ivyTemplateTypeCheck": False,
# In Google3 we still want to use the symbol factory re-exports in order to
# not break existing apps inside Google. Unlike Bazel, Google3 does not only
# enforce strict dependencies of source files, but also for generated files

0 comments on commit 572e731

Please sign in to comment.
You can’t perform that action at this time.