Skip to content

Commit

Permalink
fix(bazel): increase memory limit of ngc under bazel from 2 to 4 GB (#…
Browse files Browse the repository at this point in the history
…31784)

This commit bumps the heap size of node/ngc under bazel to 4 GB instead of
the previous 2 GB. This brings it in sync with what the TS compiler uses
in g3, and fixes a bug where ngc would crash with OOM in worker mode.

PR Close #31784
  • Loading branch information
alxhub authored and kara committed Jul 22, 2019
1 parent c845a7b commit 5a8eb92
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/bazel/src/ng_module.bzl
Expand Up @@ -353,8 +353,8 @@ _EXTRA_NODE_OPTIONS_FLAGS = [
"--node_options=--expose-gc",
# Show ~full stack traces, instead of cutting off after 10 items.
"--node_options=--stack-trace-limit=100",
# Give 2 GB RAM to node to make bigger google3 modules to compile, we should be able to drop this after Ivy/ngtsc is the default in g3
"--node_options=--max-old-space-size=2048",
# Give 4 GB RAM to node to allow bigger google3 modules to compile.
"--node_options=--max-old-space-size=4096",
]

def ngc_compile_action(
Expand Down

0 comments on commit 5a8eb92

Please sign in to comment.