Skip to content
Permalink
Browse files

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…

…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714
  • Loading branch information...
cexbrayat authored and AndrewKushnir committed May 29, 2019
1 parent bb4e230 commit 6bc9c78d76a88734e817269ea7e95a5168459833
Showing with 7 additions and 2 deletions.
  1. +6 −1 packages/core/testing/src/test_bed_common.ts
  2. +1 −1 tools/public_api_guard/core/testing.d.ts
@@ -115,8 +115,13 @@ export interface TestBedStatic {
}): TestBedStatic;

get<T>(token: Type<T>|InjectionToken<T>, notFoundValue?: T, flags?: InjectFlags): any;
// TODO: switch back to official deprecation marker once TSLint issue is resolved
// https://github.com/palantir/tslint/issues/4522
/**
* @deprecated from v8.0.0 use Type<T> or InjectionToken<T>
* deprecated from v8.0.0 use Type<T> or InjectionToken<T>
* This does not use the deprecated jsdoc tag on purpose
* because it renders all overloads as deprecated in TSLint
* due to https://github.com/palantir/tslint/issues/4522.
*/
get(token: any, notFoundValue?: any): any;

@@ -94,7 +94,7 @@ export interface TestBedStatic {
configureTestingModule(moduleDef: TestModuleMetadata): TestBedStatic;
createComponent<T>(component: Type<T>): ComponentFixture<T>;
get<T>(token: Type<T> | InjectionToken<T>, notFoundValue?: T, flags?: InjectFlags): any;
/** @deprecated */ get(token: any, notFoundValue?: any): any;
get(token: any, notFoundValue?: any): any;
initTestEnvironment(ngModule: Type<any> | Type<any>[], platform: PlatformRef, aotSummaries?: () => any[]): TestBed;
overrideComponent(component: Type<any>, override: MetadataOverride<Component>): TestBedStatic;
overrideDirective(directive: Type<any>, override: MetadataOverride<Directive>): TestBedStatic;

0 comments on commit 6bc9c78

Please sign in to comment.
You can’t perform that action at this time.