Permalink
Browse files

fix(animations): do not throw errors when a destroyed component is an…

…imated (#23836)

PR Close #23836
  • Loading branch information...
matsko committed May 10, 2018
1 parent 56be337 commit 752b83ac816b5100818bca7dbfeb17919cb99ea9
@@ -649,8 +649,11 @@ export class TransitionAnimationEngine {
trigger(namespaceId: string, element: any, name: string, value: any): boolean {
if (isElementNode(element)) {
this._fetchNamespace(namespaceId).trigger(element, name, value);
return true;
const ns = this._fetchNamespace(namespaceId);
if (ns) {
ns.trigger(element, name, value);
return true;
}
}
return false;
}
@@ -616,6 +616,13 @@ const DEFAULT_NAMESPACE_ID = 'id';
expect(element.contains(child1)).toBe(true);
expect(element.contains(child2)).toBe(true);
});
it('should not throw an error if a missing namespace is used', () => {
const engine = makeEngine();
const ID = 'foo';
const TRIGGER = 'fooTrigger';
expect(() => { engine.trigger(ID, element, TRIGGER, 'something'); }).not.toThrow();
});
});
});
})();

0 comments on commit 752b83a

Please sign in to comment.