Skip to content
Browse files

fix(ngcc): handle imports in dts files when processing UMD (#34356)

When statically evalulating UMD code it is possible to find
that we are looking for the declaration of an identifier that
actually came from a typings file (rather than a UMD file).

Previously, the UMD reflection host would always try to use
a UMD specific algorithm for finding identifier declarations,
but when the id is actually in a typings file this resulted in the
returned declaration being the containing file of the declaration
rather than the declaration itself.

Now the UMD reflection host will check to see if the file containing
the identifier is a typings file and use the appropriate stategy.

PR Close #34356
  • Loading branch information
petebacondarwin authored and kara committed Dec 11, 2019
1 parent 63366af commit 81c75cf5604861f2308494c62970da8fe5293c91
@@ -36,7 +36,8 @@ export class UmdReflectionHost extends Esm5ReflectionHost {

getDeclarationOfIdentifier(id: ts.Identifier): Declaration|null {
return this.getUmdImportedDeclaration(id) || super.getDeclarationOfIdentifier(id);
return (!id.getSourceFile().isDeclarationFile && this.getUmdImportedDeclaration(id)) ||

getExportsOfModule(module: ts.Node): Map<string, Declaration>|null {
@@ -1777,6 +1777,43 @@ runInEachFileSystem(() => {
expect(actualDeclaration !.node).toBe(expectedDeclarationNode);
expect(actualDeclaration !.viaModule).toBe('@angular/core');

it('should return the correct declaration of an identifier imported in a typings file',
() => {

const FILES = [
name: _('/node_modules/test-package/index.d.ts'),
contents: `
import {SubModule} from 'sub_module';
export const x = SubModule;
name: _('/node_modules/packages.json'),
contents: '{ "typings: "index.d.ts" }',
name: _('/node_modules/sub_module/index.d.ts'),
contents: `export class SubModule {}`,
const {program, host: compilerHost} = makeTestBundleProgram(FILES[0].name);
const host = new UmdReflectionHost(new MockLogger(), false, program, compilerHost);
const expectedDeclaration =
getDeclaration(program, FILES[2].name, 'SubModule', isNamedClassDeclaration);
const x = getDeclaration(program, FILES[0].name, 'x', isNamedVariableDeclaration);
if (x.initializer === undefined || !ts.isIdentifier(x.initializer)) {
return fail('Expected constant `x` to have an identifer as an initializer.');
const decl = host.getDeclarationOfIdentifier(x.initializer);
if (decl === null) {
return fail('Expected to find a declaration for ' + x.initializer.getText());

describe('getExportsOfModule()', () => {

0 comments on commit 81c75cf

Please sign in to comment.
You can’t perform that action at this time.