Skip to content
Permalink
Browse files

feat(bazel): compile targets used for indexing by Kythe with Ivy (#31786

)

This switches all Angular targets to be built with the same Angular compiler architecture (c.n. Ivy) that the Angular indexer uses. This eliminates issues with cross-references to transitive dependencies not being generated because of the way such dependencies are loaded by the legacy compiler arch.

PR Close #31786
  • Loading branch information...
ayazhafiz authored and mhevery committed Jul 22, 2019
1 parent 44039a4 commit 82055b2fb82a8ba6823c9667c9476889bf63ad76
Showing with 5 additions and 0 deletions.
  1. +5 −0 packages/bazel/src/ng_module.bzl
@@ -42,6 +42,11 @@ def compile_strategy(ctx):
if "compile" in ctx.var:
strategy = ctx.var["compile"]

# Enable Angular targets extracted by Kythe Angular indexer to be compiled with the Ivy compiler architecture.
# TODO(ayazhafiz): remove once Ivy has landed as the default in g3.
if ctx.var.get("GROK_ELLIPSIS_BUILD", None) != None:
strategy = "aot"

if strategy not in ["legacy", "aot"]:
fail("Unknown --define=compile value '%s'" % strategy)

0 comments on commit 82055b2

Please sign in to comment.
You can’t perform that action at this time.