Skip to content
Browse files

fix(service-worker): cache opaque responses when requests exceeds tim…

…eout threshold (#30977)

PR Close #30977
  • Loading branch information...
gkalpak authored and alxhub committed Jun 24, 2019
1 parent b0c3453 commit a9038ef13c5cf43f081574046db76e27135e0caa
Showing with 34 additions and 3 deletions.
  1. +4 −3 packages/service-worker/worker/src/data.ts
  2. +30 −0 packages/service-worker/worker/test/data_spec.ts
@@ -378,7 +378,7 @@ export class DataGroup {

// If the network fetch times out or errors, fall back on the cache.
if (res === undefined) {
ctx.waitUntil(this.safeCacheResponse(req, networkFetch));
ctx.waitUntil(this.safeCacheResponse(req, networkFetch, true));

// Ignore the age, the network response will be cached anyway due to the
// behavior of freshness.
@@ -434,9 +434,10 @@ export class DataGroup {

private async safeCacheResponse(req: Request, res: Promise<Response>): Promise<void> {
private async safeCacheResponse(req: Request, res: Promise<Response>, okToCacheOpaque?: boolean):
Promise<void> {
try {
await this.cacheResponse(req, await res, await this.lru());
await this.cacheResponse(req, await res, await this.lru(), okToCacheOpaque);
} catch {
// TODO: handle this error somehow?
@@ -259,6 +259,36 @@ import {SwTestHarness, SwTestHarnessBuilder} from '../testing/scope';
expect(await makeRequest(scope, '/refresh/data')).toEqual('this is refreshed data');

it('caches opaque responses on refresh', async() => {
// Make the initial request and populate the cache.
expect(await makeRequest(scope, '/fresh/data')).toBe('this is fresh data');

// Update the server state and pause the server, so the next request times out.
const [res, done] =
makePendingRequest(scope, new MockRequest('/fresh/data', {mode: 'no-cors'}));

// The network request times out after 1,000ms and the cached response is returned.
await serverUpdate.nextRequest;
expect(await res).toBe('this is fresh data');

// Unpause the server to allow the network request to complete and be cached.
await done;

// Pause the server to force the cached (opaque) response to be returned.
const [res2] = makePendingRequest(scope, '/fresh/data');
await serverUpdate.nextRequest;

expect(await res2).toBe('');

0 comments on commit a9038ef

Please sign in to comment.
You can’t perform that action at this time.