Skip to content

Commit

Permalink
fix(core): remove individual commands for updating gold files (#45198)
Browse files Browse the repository at this point in the history
The documented command for updating the forms gold files was outdated
and didn't work. Since this command list can easily become outdated,
remove the individual commands in favor of the simpler global scripts.

PR Close #45198
  • Loading branch information
theodorejb authored and jessicajaniuk committed Mar 1, 2022
1 parent 1b85811 commit c5df474
Showing 1 changed file with 1 addition and 14 deletions.
15 changes: 1 addition & 14 deletions packages/core/test/bundling/README.md
Expand Up @@ -3,20 +3,7 @@
## `js_expected_symbol_test`
This folder contains tests which assert that most of the code is tree shaken away.
This is asserted by keeping gold files of all symbols which are expected to be retained.
When doing renaming it is often necessary to update the gold files, to do so use these commands:

```
yarn bazel run //packages/core/test/bundling/injection:symbol_test.accept
yarn bazel run //packages/core/test/bundling/cyclic_import:symbol_test.accept
yarn bazel run //packages/core/test/bundling/forms:symbol_test.accept
yarn bazel run //packages/core/test/bundling/hello_world:symbol_test.accept
yarn bazel run //packages/core/test/bundling/router:symbol_test.accept
yarn bazel run //packages/core/test/bundling/todo:symbol_test.accept
yarn bazel run //packages/core/test/bundling/animations:symbol_test.accept
```

## Running all symbol tests
To run all symbol tests with one command, you can use the following scripts:
When doing renaming it is often necessary to update the gold files; to do so use these scripts:

```
yarn run symbol-extractor:check
Expand Down

0 comments on commit c5df474

Please sign in to comment.