Skip to content
Permalink
Browse files

build(bazel): update to nodejs rules 0.27.8 (#29508)

* fixes prodmode issue in integration/bazel

BREAKING CHANGE:

@bazel/typescript is now a peerDependency of @angular/bazel so user's of @angular/bazel must add @bazel/typescript to their package.json

PR Close #29508
  • Loading branch information...
gregmagolan authored and mhevery committed Mar 25, 2019
1 parent 06056b4 commit d9162a872dc6ea117451546f60a6a008687f78c5
@@ -15,8 +15,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Fetch rules_nodejs so we can install our npm dependencies
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = "fb87ed5965cef93188af9a7287511639403f4b0da418961ce6defb9dcf658f51",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.7/rules_nodejs-0.27.7.tar.gz"],
sha256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.8/rules_nodejs-0.27.8.tar.gz"],
)

# Check the bazel version and download npm dependencies
@@ -5,8 +5,8 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
# Fetch rules_nodejs so we can install our npm dependencies
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = "fb87ed5965cef93188af9a7287511639403f4b0da418961ce6defb9dcf658f51",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.7/rules_nodejs-0.27.7.tar.gz"],
sha256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/0.27.8/rules_nodejs-0.27.8.tar.gz"],
)

# Fetch sass rules for compiling sass files
@@ -9,9 +9,12 @@
],
"experimentalDecorators": true,
"types": [],
"module": "umd",
"module": "amd",
"moduleResolution": "node"
},
"angularCompilerOptions": {
"enableSummariesForJit": true

This comment has been minimized.

Copy link
@alexeagle

alexeagle Mar 29, 2019

Contributor

do you remember if this was actually required to make the test pass?

This comment has been minimized.

Copy link
@gregmagolan

gregmagolan Mar 29, 2019

Author Contributor

Not for integration/bazel as it wasn’t using material or routing in the ts_web_test component under test

},
"include": [
"node_modules/@angular/**/*"
],
@@ -19,7 +19,8 @@
"@angular/bazel": "packages-dist:bazel",
"@angular/compiler": "packages-dist:compiler",
"@angular/compiler-cli": "packages-dist:compiler-cli",
"@bazel/karma": "0.27.7",
"@bazel/karma": "0.27.8",
"@bazel/typescript": "0.27.8",
"@types/jasmine": "2.8.8",
"@types/source-map": "0.5.1",
"protractor": "5.1.2",
@@ -45,8 +45,5 @@ protractor_web_test_suite(
],
on_prepare = ":ts_on_prepare",
server = "//src:prodserver",
# TODO(kyliau): Re-enable once we figure out why rollup complains about
# "Dynamic requires are not currently supported by rollup-plugin-commonjs"
tags = ["manual"],
deps = [":e2e"],
)
@@ -37,8 +37,8 @@
"@angular-devkit/schematics": "^7.3.2",
"@angular/bazel": "file:./tools/npm/@angular_bazel",
"@bazel/jasmine": "0.26.0",
"@bazel/karma": "0.27.7",
"@bazel/typescript": "0.27.7",
"@bazel/karma": "0.27.8",
"@bazel/typescript": "0.27.8",
"@microsoft/api-extractor": "^7.0.21",
"@schematics/angular": "^7.3.5",
"@types/angular": "^1.6.47",
@@ -86,6 +86,7 @@
"protractor": "^5.4.2",
"reflect-metadata": "^0.1.3",
"rollup": "^1.1.0",
"rollup-plugin-amd": "^3.0.0",
"rollup-plugin-commonjs": "^9.2.1",
"rollup-plugin-node-resolve": "^4.0.0",
"rollup-plugin-sourcemaps": "^0.4.2",
@@ -22,7 +22,6 @@
"@angular-devkit/architect": "^0.13.4",
"@angular-devkit/core": "^7.0.4",
"@angular-devkit/schematics": "^7.3.0-rc.0",
"@bazel/typescript": "^0.27.7",
"@microsoft/api-extractor": "^7.0.21",
"@schematics/angular": "^7.3.5",
"@types/node": "6.0.84",
@@ -32,6 +31,7 @@
},
"peerDependencies": {
"@angular/compiler-cli": "0.0.0-PLACEHOLDER",
"@bazel/typescript": "^0.27.8",
"typescript": ">=3.3.3333 <3.4"
},
"repository": {
@@ -16,6 +16,7 @@ nodejs_binary(
"@npm//@angular-devkit/build-optimizer",
"@npm//is-builtin-module",
"@npm//rollup",
"@npm//rollup-plugin-amd",
"@npm//rollup-plugin-commonjs",
"@npm//rollup-plugin-node-resolve",
"@npm//rollup-plugin-sourcemaps",
@@ -12,8 +12,8 @@ workspace(name = "project")

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

RULES_NODEJS_VERSION = "0.27.7"
RULES_NODEJS_SHA256 = "fb87ed5965cef93188af9a7287511639403f4b0da418961ce6defb9dcf658f51"
RULES_NODEJS_VERSION = "0.27.8"
RULES_NODEJS_SHA256 = "88e5e579fb9edfbd19791b8a3c6bfbe16ae3444dba4b428e5efd36856db7cf16"
http_archive(
name = "build_bazel_rules_nodejs",
sha256 = RULES_NODEJS_SHA256,
@@ -49,7 +49,8 @@ function addDevDependenciesToPackageJson(options: Schema) {
'@angular/bazel': angularCoreVersion,
'@bazel/bazel': '^0.23.0',
'@bazel/ibazel': '^0.9.0',
'@bazel/karma': '^0.27.7',
'@bazel/karma': '^0.27.8',
'@bazel/typescript': '^0.27.8',
};

const recorder = host.beginUpdate(packageJson);
Oops, something went wrong.

0 comments on commit d9162a8

Please sign in to comment.
You can’t perform that action at this time.