Skip to content
Permalink
Browse files

fix(bazel): devserver entry_module should have underscore name (#27719)

This commit fixes a bug whereby the path of the entry_module is not
consistent with the workspace name, which does not permit dashes
in the name.

PR Close #27719
  • Loading branch information...
kyliau authored and mhevery committed Dec 18, 2018
1 parent e98c57a commit f57916c0d9a51e6815e31be8c3ba82d7ce6c4abe
@@ -58,7 +58,7 @@ ts_devserver(
"npm/node_modules/zone.js/dist",
"npm/node_modules/tslib",
],
entry_module = "<%= name %>/src/main.dev",
entry_module = "<%= utils.underscore(name) %>/src/main.dev",
serving_path = "/bundle.min.js",
static_files = [
"@npm//node_modules/zone.js:dist/zone.min.js",
@@ -42,6 +42,15 @@ describe('Bazel-workspace Schematic', () => {
expect(workspace).toMatch('ANGULAR_VERSION = "6.6.6"');
});

it('should have the correct entry_module for devserver', () => {
const options = {...defaultOptions, name: 'demo-app'};
const host = schematicRunner.runSchematic('bazel-workspace', options);
const {files} = host;
expect(files).toContain('/demo-app/src/BUILD.bazel');
const content = host.readContent('/demo-app/src/BUILD.bazel');
expect(content).toContain('entry_module = "demo_app/src/main.dev"');
});

describe('WORKSPACE', () => {
it('should contain project name', () => {
const options = {...defaultOptions};

0 comments on commit f57916c

Please sign in to comment.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.