Skip to content
Permalink
Browse files

fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get…

… overload (#30514)

PR #29290 introduced a new `TestBed.get` signature and deprecated the existing one.
This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it.

Refs #29905
Fixes FW-1336

PR Close #30514
  • Loading branch information...
cexbrayat authored and jasonaden committed May 16, 2019
1 parent 6debe9d commit f6bf8928f208c0363588c09d38c0025a5b3f76d0
Showing with 8 additions and 2 deletions.
  1. +7 −1 packages/core/testing/src/test_bed.ts
  2. +1 −1 tools/public_api_guard/core/testing.d.ts
@@ -57,8 +57,14 @@ export interface TestBed {
compileComponents(): Promise<any>;

get<T>(token: Type<T>|InjectionToken<T>, notFoundValue?: T, flags?: InjectFlags): any;

// TODO: switch back to official deprecation marker once TSLint issue is resolved
// https://github.com/palantir/tslint/issues/4522
/**
* @deprecated from v8.0.0 use Type<T> or InjectionToken<T>
* deprecated from v8.0.0 use Type<T> or InjectionToken<T>
* This does not use the deprecated jsdoc tag on purpose
* because it renders all overloads as deprecated in TSLint
* due to https://github.com/palantir/tslint/issues/4522.
*/
get(token: any, notFoundValue?: any): any;

@@ -59,7 +59,7 @@ export interface TestBed {
createComponent<T>(component: Type<T>): ComponentFixture<T>;
execute(tokens: any[], fn: Function, context?: any): any;
get<T>(token: Type<T> | InjectionToken<T>, notFoundValue?: T, flags?: InjectFlags): any;
/** @deprecated */ get(token: any, notFoundValue?: any): any;
get(token: any, notFoundValue?: any): any;
initTestEnvironment(ngModule: Type<any> | Type<any>[], platform: PlatformRef, aotSummaries?: () => any[]): void;
overrideComponent(component: Type<any>, override: MetadataOverride<Component>): void;
overrideDirective(directive: Type<any>, override: MetadataOverride<Directive>): void;

0 comments on commit f6bf892

Please sign in to comment.
You can’t perform that action at this time.