Permalink
Browse files

perf: switch angular to use StaticInjector instead of ReflectiveInjector

This change allows ReflectiveInjector to be tree shaken resulting
in not needed Reflect polyfil and smaller bundles.

Code savings for HelloWorld using Closure:

Reflective: bundle.js:  105,864(34,190 gzip)
    Static: bundle.js:  154,889(33,555 gzip)
                            645( 2%)

BREAKING CHANGE:

`platformXXXX()` no longer accepts providers which depend on reflection.
Specifically the method signature when from `Provider[]` to
`StaticProvider[]`.

Example:
Before:
```
[
  MyClass,
  {provide: ClassA, useClass: SubClassA}
]

```

After:
```
[
  {provide: MyClass, deps: [Dep1,...]},
  {provide: ClassA, useClass: SubClassA, deps: [Dep1,...]}
]
```

NOTE: This only applies to platform creation and providers for the JIT
compiler. It does not apply to `@Compotent` or `@NgModule` provides
declarations.

Benchpress note: Previously Benchpress also supported reflective
provides, which now require static providers.

DEPRECATION:

- `ReflectiveInjector` is now deprecated as it will be remove. Use
  `Injector.create` as a replacement.

closes #18496
  • Loading branch information...
mhevery authored and vicb committed Aug 3, 2017
1 parent d9d00bd commit fcadbf4bf6d00ea5b250a8069e05b3e4bd000a29
Showing with 380 additions and 279 deletions.
  1. +2 −2 modules/e2e_util/perf_util.ts
  2. +2 −0 modules/playground/README.md
  3. +1 −1 packages/benchpress/index.ts
  4. +8 −1 packages/benchpress/src/metric/perflog_metric.ts
  5. +3 −2 packages/benchpress/src/metric/user_metric.ts
  6. +5 −1 packages/benchpress/src/reporter/console_reporter.ts
  7. +7 −1 packages/benchpress/src/reporter/json_file_reporter.ts
  8. +6 −6 packages/benchpress/src/runner.ts
  9. +7 −3 packages/benchpress/src/sampler.ts
  10. +5 −1 packages/benchpress/src/validator/regression_slope_validator.ts
  11. +4 −1 packages/benchpress/src/validator/size_validator.ts
  12. +5 −2 packages/benchpress/src/webdriver/chrome_driver_extension.ts
  13. +1 −1 packages/benchpress/src/webdriver/firefox_driver_extension.ts
  14. +1 −1 packages/benchpress/src/webdriver/ios_driver_extension.ts
  15. +6 −2 packages/benchpress/src/webdriver/selenium_webdriver_adapter.ts
  16. +4 −3 packages/benchpress/test/metric/multi_metric_spec.ts
  17. +4 −4 packages/benchpress/test/metric/perflog_metric_spec.ts
  18. +3 −3 packages/benchpress/test/metric/user_metric_spec.ts
  19. +4 −4 packages/benchpress/test/reporter/console_reporter_spec.ts
  20. +2 −2 packages/benchpress/test/reporter/json_file_reporter_spec.ts
  21. +3 −3 packages/benchpress/test/reporter/multi_reporter_spec.ts
  22. +3 −3 packages/benchpress/test/runner_spec.ts
  23. +2 −2 packages/benchpress/test/sampler_spec.ts
  24. +3 −3 packages/benchpress/test/validator/regression_slope_validator_spec.ts
  25. +3 −3 packages/benchpress/test/validator/size_validator_spec.ts
  26. +3 −3 packages/benchpress/test/web_driver_extension_spec.ts
  27. +3 −3 packages/benchpress/test/webdriver/chrome_driver_extension_spec.ts
  28. +3 −3 packages/benchpress/test/webdriver/ios_driver_extension_spec.ts
  29. +2 −1 packages/common/src/directives/ng_component_outlet.ts
  30. +2 −2 packages/common/test/directives/ng_component_outlet_spec.ts
  31. +1 −1 packages/compiler/src/aot/summary_serializer.ts
  32. +42 −25 packages/compiler/src/jit/compiler_factory.ts
  33. +1 −1 packages/compiler/src/view_compiler/view_compiler.ts
  34. +1 −4 packages/compiler/test/directive_normalizer_spec.ts
  35. +1 −0 packages/compiler/test/i18n/integration_common.ts
  36. +2 −2 packages/compiler/test/i18n/integration_xliff2_spec.ts
  37. +2 −2 packages/compiler/test/i18n/integration_xliff_spec.ts
  38. +2 −2 packages/compiler/test/i18n/integration_xmb_xtb_spec.ts
  39. +3 −6 packages/compiler/test/runtime_compiler_spec.ts
  40. +1 −0 packages/compiler/test/spies.ts
  41. +1 −1 packages/compiler/test/template_parser/template_parser_spec.ts
  42. +2 −2 packages/compiler/testing/src/test_bindings.ts
  43. +9 −5 packages/compiler/testing/src/testing.ts
  44. +7 −7 packages/core/src/application_ref.ts
  45. +3 −2 packages/core/src/change_detection/differs/iterable_differs.ts
  46. +2 −2 packages/core/src/change_detection/differs/keyvalue_differs.ts
  47. +3 −2 packages/core/src/linker/compiler.ts
  48. +5 −11 packages/core/src/platform_core_providers.ts
  49. +1 −1 packages/core/src/view/query.ts
  50. +1 −1 packages/core/src/view/view.ts
  51. +4 −5 packages/core/test/change_detection/differs/iterable_differs_spec.ts
  52. +2 −3 packages/core/test/linker/integration_spec.ts
  53. +12 −3 packages/core/test/view/provider_spec.ts
  54. +3 −3 packages/core/testing/src/test_bed.ts
  55. +2 −2 packages/forms/src/directives/range_value_accessor.ts
  56. +3 −2 packages/forms/src/directives/select_control_value_accessor.ts
  57. +3 −2 packages/forms/src/directives/select_multiple_control_value_accessor.ts
  58. +5 −3 packages/forms/src/directives/validators.ts
  59. +5 −5 packages/http/test/backends/jsonp_backend_spec.ts
  60. +5 −3 packages/http/test/backends/mock_backend_spec.ts
  61. +3 −3 packages/http/test/http_spec.ts
  62. +4 −4 packages/http/testing/src/mock_backend.ts
  63. +1 −1 packages/platform-browser-dynamic/src/platform-browser-dynamic.ts
  64. +3 −3 packages/platform-browser-dynamic/src/platform_providers.ts
  65. +2 −2 packages/platform-browser-dynamic/test/resource_loader/resource_loader_cache_spec.ts
  66. +1 −1 packages/platform-browser-dynamic/testing/src/testing.ts
  67. +6 −6 packages/platform-browser/src/browser.ts
  68. +2 −2 packages/platform-browser/src/browser/server-transition.ts
  69. +3 −3 packages/platform-browser/test/browser/bootstrap_spec.ts
  70. +3 −3 packages/platform-browser/test/browser/tools/spies.ts
  71. +2 −2 packages/platform-browser/testing/src/browser.ts
  72. +9 −5 packages/platform-server/src/server.ts
  73. +7 −6 packages/platform-server/src/utils.ts
  74. +1 −1 packages/platform-server/testing/src/server.ts
  75. +1 −1 packages/platform-webworker-dynamic/src/platform-webworker-dynamic.ts
  76. +2 −2 packages/platform-webworker/src/platform-webworker.ts
  77. +11 −4 packages/platform-webworker/src/web_workers/ui/location_providers.ts
  78. +2 −1 packages/platform-webworker/src/worker_app.ts
  79. +38 −16 packages/platform-webworker/src/worker_render.ts
  80. +3 −3 packages/upgrade/src/common/downgrade_component_adapter.ts
  81. +2 −2 packages/upgrade/src/dynamic/upgrade_adapter.ts
  82. +1 −1 packages/upgrade/src/static/angular1_providers.ts
  83. +3 −3 packages/upgrade/src/static/downgrade_module.ts
  84. +8 −8 packages/upgrade/test/static/integration/downgrade_module_spec.ts
  85. +6 −6 tools/public_api_guard/core/core.d.ts
  86. +1 −1 tools/public_api_guard/platform-browser-dynamic/platform-browser-dynamic.d.ts
  87. +1 −1 tools/public_api_guard/platform-browser-dynamic/testing.d.ts
  88. +1 −1 tools/public_api_guard/platform-browser/platform-browser.d.ts
  89. +1 −1 tools/public_api_guard/platform-browser/testing.d.ts
  90. +4 −4 tools/public_api_guard/platform-server/platform-server.d.ts
  91. +1 −1 tools/public_api_guard/platform-server/testing.d.ts
  92. +1 −1 tools/public_api_guard/platform-webworker-dynamic/platform-webworker-dynamic.d.ts
  93. +4 −4 tools/public_api_guard/platform-webworker/platform-webworker.d.ts
  94. +1 −1 tools/public_api_guard/upgrade/static.d.ts
@@ -11,7 +11,7 @@ const yargs = require('yargs');
const nodeUuid = require('node-uuid');
import * as fs from 'fs-extra';
import {SeleniumWebDriverAdapter, Options, JsonFileReporter, Validator, RegressionSlopeValidator, ConsoleReporter, SizeValidator, MultiReporter, MultiMetric, Runner, Provider} from '@angular/benchpress';
import {SeleniumWebDriverAdapter, Options, JsonFileReporter, Validator, RegressionSlopeValidator, ConsoleReporter, SizeValidator, MultiReporter, MultiMetric, Runner, StaticProvider} from '@angular/benchpress';
import {readCommandLine as readE2eCommandLine, openBrowser} from './e2e_util';
let cmdArgs: {'sample-size': number, 'force-gc': boolean, 'dryrun': boolean, 'bundles': boolean};
@@ -59,7 +59,7 @@ function createBenchpressRunner(): Runner {
}
const resultsFolder = './dist/benchmark_results';
fs.ensureDirSync(resultsFolder);
const providers: Provider[] = [
const providers: StaticProvider[] = [
SeleniumWebDriverAdapter.PROTRACTOR_PROVIDERS,
{provide: Options.FORCE_GC, useValue: cmdArgs['force-gc']},
{provide: Options.DEFAULT_DESCRIPTION, useValue: {'runId': runId}}, JsonFileReporter.PROVIDERS,
@@ -1,6 +1,8 @@
# How to run the examples locally
```
$ cp -r ./modules/playground ./dist/all/
$ ./node_modules/.bin/tsc -p modules --emitDecoratorMetadata -w
$ gulp serve
$ open http://localhost:8000/all/playground/src/hello_world/index.html?bundles=false
```
@@ -9,7 +9,7 @@
// Must be imported first, because Angular decorators throw on load.
import 'reflect-metadata';
export {InjectionToken, Injector, Provider, ReflectiveInjector} from '@angular/core';
export {InjectionToken, Injector, Provider, ReflectiveInjector, StaticProvider} from '@angular/core';
export {Options} from './src/common_options';
export {MeasureValues} from './src/measure_values';
export {Metric} from './src/metric';
@@ -20,7 +20,14 @@ import {PerfLogEvent, PerfLogFeatures, WebDriverExtension} from '../web_driver_e
export class PerflogMetric extends Metric {
static SET_TIMEOUT = new InjectionToken('PerflogMetric.setTimeout');
static PROVIDERS = [
PerflogMetric, {
{
provide: PerflogMetric,
deps: [
WebDriverExtension, PerflogMetric.SET_TIMEOUT, Options.MICRO_METRICS, Options.FORCE_GC,
Options.CAPTURE_FRAMES, Options.RECEIVED_DATA, Options.REQUEST_COUNT
]
},
{
provide: PerflogMetric.SET_TIMEOUT,
useValue: (fn: Function, millis: number) => <any>setTimeout(fn, millis)
}
@@ -6,15 +6,16 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Inject, Injectable} from '@angular/core';
import {Inject, Injectable, StaticProvider} from '@angular/core';
import {Options} from '../common_options';
import {Metric} from '../metric';
import {WebDriverAdapter} from '../web_driver_adapter';
@Injectable()
export class UserMetric extends Metric {
static PROVIDERS = [UserMetric];
static PROVIDERS =
<StaticProvider[]>[{provide: UserMetric, deps: [Options.USER_METRICS, WebDriverAdapter]}];
constructor(
@Inject(Options.USER_METRICS) private _userMetrics: {[key: string]: string},
@@ -22,7 +22,11 @@ export class ConsoleReporter extends Reporter {
static PRINT = new InjectionToken('ConsoleReporter.print');
static COLUMN_WIDTH = new InjectionToken('ConsoleReporter.columnWidth');
static PROVIDERS = [
ConsoleReporter, {provide: ConsoleReporter.COLUMN_WIDTH, useValue: 18}, {
{
provide: ConsoleReporter,
deps: [ConsoleReporter.COLUMN_WIDTH, SampleDescription, ConsoleReporter.PRINT]
},
{provide: ConsoleReporter.COLUMN_WIDTH, useValue: 18}, {
provide: ConsoleReporter.PRINT,
useValue: function(v: any) {
// tslint:disable-next-line:no-console
@@ -22,7 +22,13 @@ import {formatStats, sortedProps} from './util';
@Injectable()
export class JsonFileReporter extends Reporter {
static PATH = new InjectionToken('JsonFileReporter.path');
static PROVIDERS = [JsonFileReporter, {provide: JsonFileReporter.PATH, useValue: '.'}];
static PROVIDERS = [
{
provide: JsonFileReporter,
deps: [SampleDescription, JsonFileReporter.PATH, Options.WRITE_FILE, Options.NOW]
},
{provide: JsonFileReporter.PATH, useValue: '.'}
];
constructor(
private _description: SampleDescription, @Inject(JsonFileReporter.PATH) private _path: string,
@@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Provider, ReflectiveInjector} from '@angular/core';
import {Injector, StaticProvider} from '@angular/core';
import {Options} from './common_options';
import {Metric} from './metric';
@@ -34,17 +34,17 @@ import {IOsDriverExtension} from './webdriver/ios_driver_extension';
* It provides defaults, creates the injector and calls the sampler.
*/
export class Runner {
constructor(private _defaultProviders: Provider[] = []) {}
constructor(private _defaultProviders: StaticProvider[] = []) {}
sample({id, execute, prepare, microMetrics, providers, userMetrics}: {
id: string,
execute?: Function,
prepare?: Function,
microMetrics?: {[key: string]: string},
providers?: Provider[],
providers?: StaticProvider[],
userMetrics?: {[key: string]: string}
}): Promise<SampleState> {
const sampleProviders: Provider[] = [
const sampleProviders: StaticProvider[] = [
_DEFAULT_PROVIDERS, this._defaultProviders, {provide: Options.SAMPLE_ID, useValue: id},
{provide: Options.EXECUTE, useValue: execute}
];
@@ -61,7 +61,7 @@ export class Runner {
sampleProviders.push(providers);
}
const inj = ReflectiveInjector.resolveAndCreate(sampleProviders);
const inj = Injector.create(sampleProviders);
const adapter: WebDriverAdapter = inj.get(WebDriverAdapter);
return Promise
@@ -75,7 +75,7 @@ export class Runner {
// Only WebDriverAdapter is reused.
// TODO vsavkin consider changing it when toAsyncFactory is added back or when child
// injectors are handled better.
const injector = ReflectiveInjector.resolveAndCreate([
const injector = Injector.create([
sampleProviders, {provide: Options.CAPABILITIES, useValue: capabilities},
{provide: Options.USER_AGENT, useValue: userAgent},
{provide: WebDriverAdapter, useValue: adapter}
@@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Inject, Injectable} from '@angular/core';
import {Inject, Injectable, StaticProvider} from '@angular/core';
import {Options} from './common_options';
import {MeasureValues} from './measure_values';
@@ -26,8 +26,12 @@ import {WebDriverAdapter} from './web_driver_adapter';
*/
@Injectable()
export class Sampler {
static PROVIDERS = [Sampler];
static PROVIDERS = <StaticProvider[]>[{
provide: Sampler,
deps: [
WebDriverAdapter, Metric, Reporter, Validator, Options.PREPARE, Options.EXECUTE, Options.NOW
]
}];
constructor(
private _driver: WebDriverAdapter, private _metric: Metric, private _reporter: Reporter,
private _validator: Validator, @Inject(Options.PREPARE) private _prepare: Function,
@@ -21,7 +21,11 @@ export class RegressionSlopeValidator extends Validator {
static SAMPLE_SIZE = new InjectionToken('RegressionSlopeValidator.sampleSize');
static METRIC = new InjectionToken('RegressionSlopeValidator.metric');
static PROVIDERS = [
RegressionSlopeValidator, {provide: RegressionSlopeValidator.SAMPLE_SIZE, useValue: 10},
{
provide: RegressionSlopeValidator,
deps: [RegressionSlopeValidator.SAMPLE_SIZE, RegressionSlopeValidator.METRIC]
},
{provide: RegressionSlopeValidator.SAMPLE_SIZE, useValue: 10},
{provide: RegressionSlopeValidator.METRIC, useValue: 'scriptTime'}
];
@@ -17,7 +17,10 @@ import {Validator} from '../validator';
@Injectable()
export class SizeValidator extends Validator {
static SAMPLE_SIZE = new InjectionToken('SizeValidator.sampleSize');
static PROVIDERS = [SizeValidator, {provide: SizeValidator.SAMPLE_SIZE, useValue: 10}];
static PROVIDERS = [
{provide: SizeValidator, deps: [SizeValidator.SAMPLE_SIZE]},
{provide: SizeValidator.SAMPLE_SIZE, useValue: 10}
];
constructor(@Inject(SizeValidator.SAMPLE_SIZE) private _sampleSize: number) { super(); }
@@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Inject, Injectable} from '@angular/core';
import {Inject, Injectable, StaticProvider} from '@angular/core';
import {Options} from '../common_options';
import {WebDriverAdapter} from '../web_driver_adapter';
@@ -21,7 +21,10 @@ import {PerfLogEvent, PerfLogFeatures, WebDriverExtension} from '../web_driver_e
*/
@Injectable()
export class ChromeDriverExtension extends WebDriverExtension {
static PROVIDERS = [ChromeDriverExtension];
static PROVIDERS = <StaticProvider>[{
provide: ChromeDriverExtension,
deps: [WebDriverAdapter, Options.USER_AGENT]
}];
private _majorChromeVersion: number;
private _firstRun = true;
@@ -13,7 +13,7 @@ import {PerfLogEvent, PerfLogFeatures, WebDriverExtension} from '../web_driver_e
@Injectable()
export class FirefoxDriverExtension extends WebDriverExtension {
static PROVIDERS = [FirefoxDriverExtension];
static PROVIDERS = [{provide: FirefoxDriverExtension, deps: [WebDriverAdapter]}];
private _profilerStarted: boolean;
@@ -13,7 +13,7 @@ import {PerfLogEvent, PerfLogFeatures, WebDriverExtension} from '../web_driver_e
@Injectable()
export class IOsDriverExtension extends WebDriverExtension {
static PROVIDERS = [IOsDriverExtension];
static PROVIDERS = [{provide: IOsDriverExtension, deps: [WebDriverAdapter]}];
constructor(private _driver: WebDriverAdapter) { super(); }
@@ -6,15 +6,19 @@
* found in the LICENSE file at https://angular.io/license
*/
import {StaticProvider} from '@angular/core';
import {WebDriverAdapter} from '../web_driver_adapter';
/**
* Adapter for the selenium-webdriver.
*/
export class SeleniumWebDriverAdapter extends WebDriverAdapter {
static PROTRACTOR_PROVIDERS = [{
static PROTRACTOR_PROVIDERS = <StaticProvider[]>[{
provide: WebDriverAdapter,
useFactory: () => new SeleniumWebDriverAdapter((<any>global).browser)
useFactory: () => new SeleniumWebDriverAdapter((<any>global).browser),
deps: []
}];
constructor(private _driver: any) { super(); }
@@ -7,12 +7,13 @@
*/
import {AsyncTestCompleter, describe, expect, inject, it} from '@angular/core/testing/src/testing_internal';
import {Metric, MultiMetric, ReflectiveInjector} from '../../index';
import {Injector, Metric, MultiMetric} from '../../index';
export function main() {
function createMetric(ids: any[]) {
const m = ReflectiveInjector
.resolveAndCreate([
const m = Injector
.create([
ids.map(id => ({provide: id, useValue: new MockMetric(id)})),
MultiMetric.provideWith(ids)
])
@@ -6,10 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Provider} from '@angular/core';
import {StaticProvider} from '@angular/core';
import {AsyncTestCompleter, beforeEach, describe, expect, inject, it} from '@angular/core/testing/src/testing_internal';
import {Metric, Options, PerfLogEvent, PerfLogFeatures, PerflogMetric, ReflectiveInjector, WebDriverExtension} from '../../index';
import {Injector, Metric, Options, PerfLogEvent, PerfLogFeatures, PerflogMetric, WebDriverExtension} from '../../index';
import {TraceEventFactory} from '../trace_event_factory';
export function main() {
@@ -33,7 +33,7 @@ export function main() {
if (!microMetrics) {
microMetrics = {};
}
const providers: Provider[] = [
const providers: StaticProvider[] = [
Options.DEFAULT_PROVIDERS, PerflogMetric.PROVIDERS,
{provide: Options.MICRO_METRICS, useValue: microMetrics}, {
provide: PerflogMetric.SET_TIMEOUT,
@@ -59,7 +59,7 @@ export function main() {
if (requestCount != null) {
providers.push({provide: Options.REQUEST_COUNT, useValue: requestCount});
}
return ReflectiveInjector.resolveAndCreate(providers).get(PerflogMetric);
return Injector.create(providers).get(PerflogMetric);
}
describe('perflog metric', () => {
@@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Provider, ReflectiveInjector} from '@angular/core';
import {Injector, StaticProvider} from '@angular/core';
import {AsyncTestCompleter, describe, expect, inject, it} from '@angular/core/testing/src/testing_internal';
import {Options, PerfLogEvent, PerfLogFeatures, UserMetric, WebDriverAdapter} from '../../index';
@@ -25,12 +25,12 @@ export function main() {
userMetrics = {};
}
wdAdapter = new MockDriverAdapter();
const providers: Provider[] = [
const providers: StaticProvider[] = [
Options.DEFAULT_PROVIDERS, UserMetric.PROVIDERS,
{provide: Options.USER_METRICS, useValue: userMetrics},
{provide: WebDriverAdapter, useValue: wdAdapter}
];
return ReflectiveInjector.resolveAndCreate(providers).get(UserMetric);
return Injector.create(providers).get(UserMetric);
}
describe('user metric', () => {
@@ -6,10 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/
import {Provider} from '@angular/core';
import {StaticProvider} from '@angular/core';
import {describe, expect, it} from '@angular/core/testing/src/testing_internal';
import {ConsoleReporter, MeasureValues, ReflectiveInjector, SampleDescription} from '../../index';
import {ConsoleReporter, Injector, MeasureValues, SampleDescription} from '../../index';
export function main() {
describe('console reporter', () => {
@@ -30,7 +30,7 @@ export function main() {
if (sampleId == null) {
sampleId = 'null';
}
const providers: Provider[] = [
const providers: StaticProvider[] = [
ConsoleReporter.PROVIDERS, {
provide: SampleDescription,
useValue: new SampleDescription(sampleId, descriptions, metrics !)
@@ -40,7 +40,7 @@ export function main() {
if (columnWidth != null) {
providers.push({provide: ConsoleReporter.COLUMN_WIDTH, useValue: columnWidth});
}
reporter = ReflectiveInjector.resolveAndCreate(providers).get(ConsoleReporter);
reporter = Injector.create(providers).get(ConsoleReporter);
}
it('should print the sample id, description and table header', () => {
@@ -8,7 +8,7 @@
import {AsyncTestCompleter, describe, expect, inject, it} from '@angular/core/testing/src/testing_internal';
import {JsonFileReporter, MeasureValues, Options, ReflectiveInjector, SampleDescription} from '../../index';
import {Injector, JsonFileReporter, MeasureValues, Options, SampleDescription} from '../../index';
export function main() {
describe('file reporter', () => {
@@ -34,7 +34,7 @@ export function main() {
}
}
];
return ReflectiveInjector.resolveAndCreate(providers).get(JsonFileReporter);
return Injector.create(providers).get(JsonFileReporter);
}
it('should write all data into a file',
@@ -8,12 +8,12 @@
import {AsyncTestCompleter, describe, expect, inject, it} from '@angular/core/testing/src/testing_internal';
import {MeasureValues, MultiReporter, ReflectiveInjector, Reporter} from '../../index';
import {Injector, MeasureValues, MultiReporter, Reporter} from '../../index';
export function main() {
function createReporters(ids: any[]) {
const r = ReflectiveInjector
.resolveAndCreate([
const r = Injector
.create([
ids.map(id => ({provide: id, useValue: new MockReporter(id)})),
MultiReporter.provideWith(ids)
])
Oops, something went wrong.

0 comments on commit fcadbf4

Please sign in to comment.