Skip to content
Permalink
Branch: master
Commits on Apr 19, 2019
  1. build: publish ts-api-guardian rule in the npm package (#29977)

    alan-agius4 authored and benlesh committed Apr 19, 2019
    With this change downstream users will no longer need to build ts-api-guardian from source as now the bazel rule is available in the npm package.
    
    This can be used by installing ts-api-guardian as a devDependency and changing the load syntax from:
    ```
    load("@angular//tools/ts-api-guardian:index.bzl", "ts_api_guardian_test")
    ```
    
    to:
    ```
    load("@npm_ts_api_guardian//:index.bzl", "ts_api_guardian_test")
    ```
    
    **Note**: downstream users should also clean their `WORKSPACE` and remove the dependencies of angular workspace.
    
    PR Close #29977
Commits on Apr 17, 2019
  1. fix(core): don't include a local `EventListener` in typings (#29809)

    alan-agius4 authored and benlesh committed Apr 10, 2019
    With dts bundles, `core.d.ts` will include an `EventListener` class as it's used in https://github.com/angular/angular/blob/303eae918d997070a36b523ddc97e018f622c258/packages/core/src/debug/debug_node.ts#L32
    
    This will conflict with the DOM EventListener, as anything in `core.d.ts` which is using the DOM EventListener will fallback in using the one defined in the same module and hence build will fail because their implementation is different.
    
    With this change, we rename the local `EventListener` to `DebugEventListener`, the later one is non exported.
    
    Fixes #29806
    
    PR Close #29809
Commits on Apr 10, 2019
  1. docs: update path mappings and exports (#29810)

    alan-agius4 authored and IgorMinar committed Apr 10, 2019
    1) Path mappings are to be added in the workspace tsconfig files, hence the path needs to be `./` and not `../`
    2) Fix export symbol as it cannot contain `-`
    
    Fixes #29807
    
    PR Close #29810
Commits on Apr 8, 2019
  1. feat(bazel): update the build to use the new architect api (#29720)

    alan-agius4 authored and IgorMinar committed Apr 5, 2019
    With this change the builder has been updated to use the latest architect API and make it compatable with the latest CLI
    
    Fixes angular/angular-cli#14082
    
    PR Close #29720
Commits on Apr 3, 2019
  1. fix(bazel): support running ng-add on minimal applications (#29681)

    alan-agius4 authored and jasonaden committed Apr 3, 2019
    Minimal applications don't have `test` and `e2e` targets but we are not currently checking if they exists.
    
    Fixes #29680
    
    PR Close #29681
Commits on Mar 21, 2019
  1. docs: add app shell guide (#28591)

    alan-agius4 authored and mhevery committed Feb 7, 2019
    PR Close #28591
Commits on Mar 20, 2019
  1. test: remove symlink workaround (#29426)

    alan-agius4 authored and matsko committed Mar 20, 2019
    This is no longer required. And is causing some errors to some of our engineers
    
    PR Close #29426
Commits on Mar 15, 2019
  1. docs: update universal project structure (#29332)

    alan-agius4 authored and matsko committed Mar 15, 2019
    In version 8 the project structure is slightly different
    
    PR Close #29332
Commits on Mar 12, 2019
  1. fix(bazel): add missing binary path for api-extractor (#29202)

    alan-agius4 authored and kara committed Mar 9, 2019
    `api-extractor` binary is required for external consumers of `ng_module` that want to use the `bundle_dts` flag.
    
    This also sets a different api-exttractor binary to use for ng_module, based if it's internal or external.
    
    PR Close #29202
Commits on Mar 11, 2019
  1. fix(ivy): always convert `rootDirs` to `AbsoluteFsPath` in `getRootDi…

    alan-agius4 authored and kara committed Mar 7, 2019
    …rs` (#29151)
    
    `getCurrentDirectory` directory doesn't return a posix separated normalized path. While `rootDir` and `rootDirs` should return posix separated paths, it's best to not assume as other paths within the compiler options can be returned not posix separated such as `basePath`
    
    See: https://github.com/Microsoft/TypeScript/blob/master/src/compiler/sys.ts#L635
    
    This partially fixes #29140, however there needs to be a change in the CLI as well to handle this, as at the moment we are leaking devkit paths which is not correct.
    
    Fixes #29140
    
    PR Close #29151
  2. fix(ivy): render alias exports for private declarations if possible (#…

    alan-agius4 authored and kara committed Feb 14, 2019
    …28735)
    
    Sometimes declarations are not exported publicly but are exported under
    a private name. In this case, rather than adding a completely new
    export to the entry point, we should create an export that aliases the
    private name back to the original public name.
    
    This is important when the typings files have been rolled-up using a tool
    such as the [API Extractor](https://api-extractor.com/). In this case
    the internal type of an aliased private export will be removed completely
    from the typings file, so there is no "original" type to re-export.
    
    For example:
    
    If there are the following TS files:
    
    **entry-point.ts**
    
    ```ts
    export {Internal as External} from './internal';
    ```
    
    **internal.ts**
    
    ```ts
    export class Internal {
      foo(): void;
    }
    ```
    
    Then the API Extractor might roll up the .d.ts files into:
    
    ```ts
    export declare class External {
      foo(): void;
    }
    ```
    
    In this case ngcc should add an export so the file looks like:
    
    ```ts
    export declare class External {
      foo(): void;
    }
    export {External as Internal};
    ```
    
    PR Close #28735
Commits on Mar 8, 2019
  1. test: add interm fix for test that rely on an index.d.ts file (#28884)

    alan-agius4 authored and kara committed Mar 6, 2019
    At the moment, certain tests relies on resolving the module with an index.d.ts, this root cause might be some implementations are missing from the mocks.
    
    Similar to: 58b4045
    
    PR Close #28884
  2. test: fix ngcc tests to work with flattened dts files (#28884)

    alan-agius4 authored and kara committed Mar 6, 2019
    PR Close #28884
  3. build: enable bundle_dts for core package (#28884)

    alan-agius4 authored and kara committed Mar 6, 2019
    `ng_module` will now include an `src/r3_symbol.d.ts` when compiling the core package under `ngc` togather with `dts bundling`, This is due that `ngcc` relies on this file to be present, but the `r3_symbols` file which is not part of our public api.
    
    With this change, we can now ship an addition dts file which is flattened.
    
    PR Close #28884
Commits on Mar 7, 2019
  1. build: remove now redundant `bundle_dts = True` attribute (#29128)

    alan-agius4 authored and kara committed Mar 6, 2019
    This is now turned on by default in the ng_module macro
    
    PR Close #29128
  2. build: enable dts bundling by default for public facing packages (#29128

    alan-agius4 authored and kara committed Mar 6, 2019
    )
    
    With this change dts bundling is turned on by default for public facing packages
    
    PR Close #29128
  3. build: turn off dts bundling for packages that still are not supported (

    alan-agius4 authored and kara committed Mar 6, 2019
    #29128)
    
    PR Close #29128
  4. build: enable bundle_dts for router package (#28833)

    alan-agius4 authored and kara committed Feb 19, 2019
    This PR also changes the name of `EmptyOutletComponent` to `ɵEmptyOutletComponent`. This is because `ngcc` requires the node to retain the original name while dts bundler will rename the node is it's only exported using the aliases.
    
    Example typings files:
    ```ts
    declare class EmptyOutletComponent {
    }
    export {EmptyOutletComponent as ɵEmptyOutletComponent}
    ```
    
    will be emitted as
    ```ts
    export declare class ɵEmptyOutletComponent {
    }
    ```
    
    PR Close #28833
Commits on Mar 6, 2019
  1. test: fix dts path to the flattened file (#28834)

    alan-agius4 authored and AndrewKushnir committed Mar 6, 2019
    PR Close #28834
  2. build: enable bundle_dts for common package (#28834)

    alan-agius4 authored and AndrewKushnir committed Feb 20, 2019
    PR Close #28834
Commits on Mar 5, 2019
  1. refactor: remove unused functions and classes in diagnostics (#28923)

    alan-agius4 authored and AndrewKushnir committed Feb 22, 2019
    PR Close #28923
  2. test: fix resolution to not depend on index.d.ts (#28854)

    alan-agius4 authored and AndrewKushnir committed Feb 25, 2019
    Implement `readFile` in `MockTypescriptHost` so TypeScript can resolve module based on it's resolution, since certain files are not on disk but in memory
    
    PR Close #28854
  3. build: enable bundle_dts for forms package (#28854)

    alan-agius4 authored and AndrewKushnir committed Feb 20, 2019
    This PR also changes the name of NgNoValidate` to `ɵNgNoValidate`. This is because `ngcc` requires the node to retain the original name while dts bundler will rename the node is it's only exported using the aliases.
    
    Example typings files:
    ```ts
    declare class NgNoValidate{
    }
    export {NgNoValidateas ɵNgNoValidate}
    ```
    
    will be emitted as
    ```ts
    export declare class ɵNgNoValidate {
    }
    ```
    
    PR Close #28854
  4. ci: update packageFiles to be renovated (#29071)

    alan-agius4 authored and AndrewKushnir committed Mar 2, 2019
    Change `cli-hello-world-ivy` to `cli-hello-world-compat` as this was renamed and add `cli-hello-world-ivy-minimal`.
    PR Close #29071
Commits on Mar 1, 2019
  1. fix(bazel): api extractor don't generate tsdoc metadata (#29023)

    alan-agius4 authored and AndrewKushnir committed Mar 1, 2019
    tsdoc metadata is not needed for `ng_module` and with `@microsoft/api-extractor` version 7.0.21 there is a new flag to disable it's generation.
    
    See: Microsoft/web-build-tools#1051
    
    PR Close #29023
  2. docs: add how to create a minimal repo in bug report template (#29022)

    alan-agius4 authored and AndrewKushnir committed Feb 28, 2019
    PR Close #29022
Commits on Feb 27, 2019
  1. feat(ivy): add support for windows concrete types for paths (#28752)

    alan-agius4 authored and benlesh committed Feb 16, 2019
    This commit introduces support for the windows paths in the new concrete types mechanism that was introduced in this PR #28523
    
    Normalized posix paths that start with either a `/` or `C:/` are considered to be an absolute path.
    
    Note: `C:/` is used as a reference, as other drive letters are also supported.
    
    Fixes #28754
    
    PR Close #28752
Commits on Feb 22, 2019
  1. build: enable bundle_dts for a upgrade package (#28642)

    alan-agius4 authored and IgorMinar committed Feb 14, 2019
    PR Close #28642
  2. test: update upgrade golden file (#28642)

    alan-agius4 authored and IgorMinar committed Feb 11, 2019
    PR Close #28642
  3. refactor: replace local namespaced imports with named (#28642)

    alan-agius4 authored and IgorMinar committed Feb 11, 2019
    At the moment, the API extractor doesn't support local namespaced imports, this will break the generation of flat dts files. When we turn on dts bundling for this package it will break. Hence this is the ground work needed for making this package compatable with the API extractor.
    
    See: Microsoft/web-build-tools#1029
    
    Relates to #28588
    
    PR Close #28642
Commits on Feb 20, 2019
  1. build: enable bundle_dts for a number of packages (#28726)

    alan-agius4 authored and IgorMinar committed Feb 19, 2019
    This change enables dts bundling for the following packages and their secondary entry points:
    
    - @angular/animations
    - @angular/elements
    - @angular/http
    - @angular/platform-browser
    - @angular/platform-browser-dynamic
    - @angular/platform-server
    - @angular/platform-webworker
    - @angular/platform-webworker-dynamic
    - @angular/servce-worker
    
    Dts bundling happens in `ng_module` bazel definition, hence packages such as `@angular/compiler`, `@angular/compiler-cli` and `@angular/langauge service` cannot be flattened as they use `ts_library`.
    
    `@angular/core`, `@angular/common`, `@angular/upgrade` and `@angular/forms` will be done seperatly as it requires some changes either to their source or specs.
    
    PR Close #28726
Commits on Feb 19, 2019
  1. ci: add renovate configuration (#28121)

    alan-agius4 authored and IgorMinar committed Jan 14, 2019
    This will be important to keep the CLI / Framework changes in sync and not to have size regressions.
    
    TOOL-582 #resolve
    
    PR Close #28121
Commits on Feb 14, 2019
  1. build: update `@microsoft/api-extractor` to `7.0.17` (#28588)

    alan-agius4 authored and mhevery committed Feb 11, 2019
    This fixes one of the problems that we reported Microsoft/web-build-tools#1048
    
    PR Close #28588
Older
You can’t perform that action at this time.