Skip to content
Permalink
Branch: master
Commits on Jun 14, 2019
  1. fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…

    cexbrayat authored and AndrewKushnir committed May 29, 2019
    …ic.get overload (#30714)
    
    Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.
    
    PR Close #30714
Commits on May 21, 2019
  1. fix(core): temporarily remove @deprecated jsdoc tag for a TextBed.get…

    cexbrayat authored and jasonaden committed May 16, 2019
    … overload (#30514)
    
    PR #29290 introduced a new `TestBed.get` signature and deprecated the existing one.
    This raises a lot of TSLint deprecation warnings in projects using a strict TS config (see #29905 for context), so we are temporarily removing the `@deprecated` annotation in favor of a plain text warning until we properly fix it.
    
    Refs #29905
    Fixes FW-1336
    
    PR Close #30514
Commits on May 17, 2019
  1. feat(common): stricter types for SlicePipe (#30156)

    cexbrayat authored and jasonaden committed Apr 26, 2019
    Adds overloads to the `transform` methods of `SlicePipe`,
    to have better types than `any` for `value` and `any` as a return.
    With this commit, using `slice` in an `ngFor` still allow to type-check the content of the `ngFor`
    with `fullTemplateTypeCheck` enabled in Ivy:
    
        <div *ngFor="let user of users | slice:0:2">{{ user.typo }}</div>
                                                            |
                                                            `typo` does not exist on type `UserModel`
    
    whereas it is currently not catched (as the return of `slice` is `any`) neither in VE nor in Ivy.
    
    BREAKING CHANGE
    `SlicePipe` now only accepts an array of values, a string, null or undefined.
    This was already the case in practice, and it still throws at runtime if another type is given.
    But it is now a compilation error to try to call it with an unsupported type.
    
    PR Close #30156
Commits on May 14, 2019
  1. test(ivy): move common integration tests to acceptance (#30213)

    cexbrayat authored and alxhub committed Apr 30, 2019
    PR Close #30213
Commits on May 7, 2019
  1. fix(core): consistently use ng:/// for sourcemap URLs (#29826)

    cexbrayat authored and kara committed Apr 11, 2019
    Currently, in jit mode, `ngInjectableDef`, `ngDirectiveDef`, `ngPipeDef` and `ngModuleDef` use `ng://`,
    which display them in the top domain in Chrome Dev Tools, whereas `ngComponentDef` uses `ng:///` which display components in a separate domain.
    
    You can currently see:
    
    ```
    AppModule
    UserService
    ng://
    |_ AppComponent
       |_ template.html
    |_ AppComponent.js
    ...
    ```
    
    This commits replaces all `ng://` with `ng:///` to display every Angular entity in the `ng://` domain.
    
    ```
    ng://
    |_ AppModule
    |_ UserService
    |_ AppComponent
    ...
    ```
    
    PR Close #29826
Commits on Apr 26, 2019
  1. refactor(ivy): move exports tests to acceptance (#30157)

    cexbrayat authored and AndrewKushnir committed Apr 26, 2019
    PR Close #30157
  2. refactor(ivy): move di tests for inject to acceptance (#29299)

    cexbrayat authored and AndrewKushnir committed Mar 30, 2019
    PR Close #29299
  3. refactor(ivy): move di tests for flags to acceptance (#29299)

    cexbrayat authored and AndrewKushnir committed Mar 30, 2019
    Including tests for `@optional`, `@self`, `@SkipSelf` and `@host`.
    
    PR Close #29299
  4. refactor(ivy): move di tests for DI tokens to acceptance (#29299)

    cexbrayat authored and AndrewKushnir committed Mar 19, 2019
    Move tests for special tokens like `Injector`, `ElementRef`, `TemplateRef`, `ViewContainerRef`, `ChangeDectetorRef` and custom string tokens.
    
    PR Close #29299
Commits on Apr 2, 2019
  1. docs: fix typos in getting-started (#29665)

    cexbrayat authored and jasonaden committed Apr 1, 2019
    PR #27684 introduced a new getting-started guide and a few typos slipped through the review.
    
    PR Close #29665
Commits on Apr 1, 2019
  1. docs: improve formatDate description (#29632)

    cexbrayat authored and jasonaden committed Apr 1, 2019
    PR #29289 reworded the description, making it less obvious that the value to format can be a `Date`.
    
    PR Close #29632
Commits on Mar 14, 2019
  1. fix(ivy): do not inject attributes with namespace (#29257)

    cexbrayat authored and matsko committed Mar 13, 2019
    When injecting with `@Attribute`, namespaced attributes should not match (in order to have feature parity with View Engine).
    
    This PR resolves FW-1137
    
    PR Close #29257
Commits on Feb 13, 2019
  1. refactor(ivy): remove unused parameter in postProcessBaseDirective (#…

    cexbrayat authored and mhevery committed Feb 9, 2019
    …28631)
    
    https://github.com/angular/angular/pull/28089/files#diff-ce885db4223480bd4f7b78bd22b6f058L1650 removed the use of `def` in `postProcessBaseDirective`, making the parameter now useless.
    
    PR Close #28631
  2. refactor(ivy): remove unused notImplement function (#28630)

    cexbrayat authored and mhevery committed Feb 9, 2019
    It has not been used since #27387 implemented the last missing methods in DebugNode
    
    PR Close #28630
Commits on Feb 6, 2019
  1. docs(service-worker): note about isStable/setInterval (#28102)

    cexbrayat authored and matsko committed Jan 12, 2019
    The docs don't mention that the app will never be stable if a `setInterval` is running somewhere, and that it will prevent the servcie worker to be registered too.
    
    PR Close #28102
  2. docs(core): document isStable traps (#28102)

    cexbrayat authored and matsko committed Jan 13, 2019
    PR Close #28102
Commits on Jan 30, 2019
  1. fix(ivy): scan simple children routes with no infinite recursion (#28370

    cexbrayat authored and jasonaden committed Jan 25, 2019
    )
    
    PR Close #28370
Commits on Jan 15, 2019
  1. fix(ivy): deps are actually supported (#28076)

    cexbrayat authored and AndrewKushnir committed Jan 11, 2019
    This code was throwing if the `deps` array of a provider has several elements, but at the next line it resolves them... With this check `ngtsc` couldn’t compile `ng-bootstrap` for example.
    
    PR Close #28076
Commits on Jan 9, 2019
  1. test: fix outDir in TS 3.2 integration test (#27774)

    cexbrayat authored and kara committed Dec 20, 2018
    PR Close #27774
Commits on Dec 26, 2018
  1. test: check payload size for cli-hello-world-ivy (#27797)

    cexbrayat authored and benlesh committed Dec 21, 2018
    Adds size bundle checking to the integration test `cli-hello-world-ivy`
    
    PR Close #27797
  2. test: update cli-hello-world-ivy to cli@7.2.0-rc.0 (#27797)

    cexbrayat authored and benlesh committed Dec 14, 2018
    Updates the app itself to reflect the result of using the  `experimentalIvy` flag on the CLI.
    The result is similar to:
    
        npx @angular/cli@next new cli-hello-world-ivy --experimental-ivy --defaults
    
    But replaces the current (cli `7.2.0-rc.0`) `renderComponent` bootstrap with the usual `platformBrowserDynamic` one.
    It also keeps what the app did (display a pipe, tests it).
    
    PR Close #27797
Commits on Dec 14, 2018
  1. docs(router): typo in state documentation (#27671)

    cexbrayat authored and mhevery committed Dec 14, 2018
    PR Close #27671
Commits on Dec 7, 2018
  1. fix(forms): typed argument for FormBuilder group (#26985)

    cexbrayat authored and alxhub committed Nov 7, 2018
    PR Close #26985
Commits on Nov 13, 2018
  1. fix(ivy): ngcc should not fail on invalid package.json (#26539)

    cexbrayat authored and AndrewKushnir committed Oct 18, 2018
    Some package.json files may have invalid JSON, for example package.json blueprints from `@schematics/angular` (see https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/workspace/files/package.json).
    
    This makes ngcc more resilient, by simpling logging a warning if an error is encountered, instead of failing as it does right now.
    
    PR Close #26539
Commits on Oct 15, 2018
  1. style: typos in TS 3.1 integration test (#26433)

    cexbrayat authored and mhevery committed Oct 13, 2018
    The test was mentionning TS 3.0.
    
    PR Close #26433
Commits on Sep 11, 2018
  1. fix(ivy): use proper sanitizer names (#25817)

    cexbrayat authored and IgorMinar committed Sep 5, 2018
    Fixes #25816
    
    PR Close #25817
Commits on Jul 23, 2018
  1. docs: tests for number/percent/currency pipe (#25028)

    cexbrayat authored and vicb committed Jun 25, 2018
    Will avoid errors in examples like the one fixed in #24661
    
    Closes #25028
Commits on Jul 20, 2018
  1. docs: more info on currency digits (#24661)

    cexbrayat authored and vicb committed Jun 25, 2018
    Adds an example of using the `currency` pipe with a currency that has no cents like CLP,
    which will format the amount with no digits if `digitsInfo` is not provided:
    
        <!-- outputs CA$14.00 -->
        {{ 14 | currency:'CAD' }}
        <!-- outputs CLP14 -->
        {{ 14 | currency:'CLP' }}
    
    Amends the docs, adds an example and fix an error with a current example.
    
    PR Close #24661
Commits on Jul 17, 2018
  1. docs: typos in directives docs (#24665)

    cexbrayat authored and matsko committed Jun 25, 2018
    Fixes some typos introduced by #23902
    
    PR Close #24665
Commits on Jul 6, 2018
  1. fix(ivy): pipes are pure by default (#24750)

    cexbrayat authored and mhevery committed Jul 3, 2018
    PR Close #24750
  2. test: integration test for TS 2.9.x (#24749)

    cexbrayat authored and mhevery committed Jul 3, 2018
    PR Close #24749
Commits on Jun 14, 2018
  1. test(common): rename keyvalue e2e test (#24489)

    cexbrayat authored and mhevery committed Jun 13, 2018
    PR Close #24489
Commits on May 29, 2018
  1. refactor(core): use Partial<T> for MetadataOverride (#24103)

    cexbrayat authored and matsko committed May 24, 2018
    Allows to write:
    
    const fixture = TestBed
          .overridePipe(DisplayNamePipe, { set: { pure: false } })
          .createComponent(MenuComponent);
    
    when you only want to set the `pure` metadata,
    instead of currently:
    
    const fixture = TestBed
          .overridePipe(DisplayNamePipe, { set: { name: 'displayName', pure: false } })
          .createComponent(MenuComponent);
    
    which forces you to redefine the name of the pipe even if it is useless.
    
    Fixes #24102
    
    PR Close #24103
Older
You can’t perform that action at this time.