Skip to content
Permalink
Branch: master
Commits on Apr 25, 2019
  1. docs: copy edits to Ivy opt-in (#29955)

    filipesilva authored and AndrewKushnir committed Apr 22, 2019
    PR Close #29955
  2. docs: remove aot step from Ivy opt-in (#29955)

    filipesilva authored and AndrewKushnir committed Apr 17, 2019
    PR Close #29955
Commits on Apr 18, 2019
  1. feat(compiler-cli): export tooling definitions (#29929)

    filipesilva authored and benlesh committed Apr 17, 2019
    PR Close #29929
  2. fix(core): use shakeable global definitions (#29929)

    filipesilva authored and benlesh committed Apr 16, 2019
    The `ngDevMode` and `ngI18nClosureMode` are special in that they should be set to `false` on production builds in order to shake out code associated with it.
    
    Angular CLI does this in https://github.com/angular/angular-cli/blob/5fc1f2499cbe57f9a95e4b0dfced130eb3a8046d/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L279-L282.
    
    But in #28689 the toplevel usage was changed from `ngDevMode` to `global['ngDevMode']` (and the same for `ngI18nClosureMode`). This indirection prevents the static analysis in Terser from effecting the replacement.
    
    PR Close #29929
Commits on Apr 16, 2019
  1. fix(compiler-cli): pass config path to ts.parseJsonConfigFileContent (#…

    filipesilva authored and alxhub committed Apr 12, 2019
    …29872)
    
    The config path is an optional argument to `ts.parseJsonConfigFileContent`. When passed, it is added to the returned object as `options.configFilePath`, and `tsc` itself passes it in.
    
    The new TS 3.4 [incremental](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html) build functionality relies on this property being present: https://github.com/Microsoft/TypeScript/blob/025d82633915b67003ea38ba40b9239a19721c13/src/compiler/emitter.ts#L56-L57
    
    When using The compiler-cli `readConfiguration` the config path option isn't passed, preventing consumers (like @ngtools/webpack) from obtaining a complete config object.
    
    This PR fixes this omission and should allow JIT users of @ngtools/webpack to set the `incremental` option in their tsconfig and have it be used by the TS program.
    
    I tested this in JIT and saw a small decrease in build times in a small project. In AOT the incremental option didn't seem to be used at all, due to how `ngc` uses the TS APIs.
    
    Related to angular/angular-cli#13941.
    
    PR Close #29872
  2. fix(router): support non-NgFactory promise in loadChildren typings (#…

    filipesilva authored and alxhub committed Apr 11, 2019
    …29832)
    
    PR Close #29832
Commits on Apr 15, 2019
  1. build(docs-infra): convert `search-worker.js` to TypeScript (#29764)

    filipesilva authored and alxhub committed Apr 15, 2019
    PR Close #29764
  2. build(docs-infra): update to CLI 8 beta.13 (#29764)

    filipesilva authored and alxhub committed Apr 15, 2019
    PR Close #29764
Commits on Apr 13, 2019
  1. test: ensure correct TS version before running postinstall (#29885)

    filipesilva authored and alxhub committed Apr 13, 2019
    The bazel-schematics test could suffer from a version skew where new CLI projects were not yet using a new TS version, but Angular packages already were.
    
    This caused the the `ngc` call in the added `postinstall` to run and fail: https://circleci.com/gh/angular/angular/283109
    
    PR Close #29885
Commits on Apr 12, 2019
  1. test(docs-infra): ignore lazy loading examples in Ivy (#28685)

    filipesilva authored and alxhub committed Apr 9, 2019
    PR Close #28685
Commits on Apr 10, 2019
  1. build: update to TypeScript 3.4 (#29372)

    filipesilva authored and IgorMinar committed Mar 18, 2019
    PR Close #29372
Commits on Apr 4, 2019
  1. fix(core): add missing migration to npm package (#29705)

    filipesilva authored and jasonaden committed Apr 4, 2019
    While running `ng update @angular/core --next`, the following error would be displayed:
    
    ```
    Cannot find module '....\node_modules\@angular\core\schematics\migrations\template-var-assignment\index'
    ```
    
    This happened because the Schematics migration was referenced, but not included.
    
    This commit fixes that bug by including the migration in the Bazel npm package dependencies.
    
    PR Close #29705
Commits on Apr 1, 2019
  1. docs: add Web Worker guide (#29633)

    filipesilva authored and jasonaden committed Apr 1, 2019
    Followup to angular/angular-cli#13700
    
    PR Close #29633
  2. docs: remove ngcc steps from Ivy opt-in (#29506)

    filipesilva authored and jasonaden committed Mar 25, 2019
    PR Close #29506
  3. docs: add Ivy lazy load opt-in (#29506)

    filipesilva authored and jasonaden committed Mar 25, 2019
    PR Close #29506
Commits on Mar 29, 2019
  1. build: make VSCode settings opt-in (#29504)

    filipesilva authored and jasonaden committed Mar 28, 2019
    PR Close #29504
Commits on Mar 27, 2019
  1. ci: update windows CI bazelrc (#29542)

    filipesilva authored and mhevery committed Mar 27, 2019
    PR Close #29542
Commits on Mar 25, 2019
  1. fix(router): support NgFactory promise in loadChildren typings (#29392)

    filipesilva authored and mhevery committed Mar 19, 2019
    The router loadChildren property already supports a promise that returns a NgModuleFactory, but the typings cause the compilation to fail.
    
    PR Close #29392
Commits on Mar 21, 2019
  1. ci: add codefresh (#29305)

    filipesilva authored and mhevery committed Mar 14, 2019
    PR Close #29305
Commits on Mar 12, 2019
  1. ci: rebase PRs on target branch (#29215)

    filipesilva authored and kara committed Mar 11, 2019
    PR Close #29215
  2. ci: add descriptive message for merge conflicts (#29215)

    filipesilva authored and kara committed Mar 11, 2019
    Fix #29199
    
    PR Close #29215
Commits on Mar 6, 2019
  1. docs: update ivy opt-in flag (#29010)

    filipesilva authored and AndrewKushnir committed Feb 27, 2019
    Followup to #28569 (comment) and angular/angular-cli#13773.
    
    Note: this flag will only work on `@angular/cli@8.0.0-beta.3` (currently unreleased) and above.
    
    PR Close #29010
Commits on Feb 26, 2019
  1. docs: add ivy opt-in docs (#28569)

    filipesilva authored and benlesh committed Feb 6, 2019
    PR Close #28569
Commits on Feb 25, 2019
  1. ci: add bazel_repository_cache to CircleCI workspace (#28935)

    filipesilva authored and benlesh committed Feb 25, 2019
    PR Close #28935
  2. ci: rename install job to setup (#28935)

    filipesilva authored and benlesh committed Feb 22, 2019
    Followup to #28928 (review)
    
    PR Close #28935
  3. ci: update aio lockfile (#28935)

    filipesilva authored and benlesh committed Feb 25, 2019
    PR Close #28935
Commits on Feb 22, 2019
  1. fix(compiler): use correct variable in invalid function (#28656)

    filipesilva authored and benlesh committed Feb 12, 2019
    Related to #26743 (but does not close it).
    
    PR Close #28656
  2. ci: share data between jobs using workspaces (#28928)

    filipesilva authored and benlesh committed Feb 22, 2019
    PR Close #28928
  3. ci: update circleci post checkout to v2 syntax (#28472)

    filipesilva authored and IgorMinar committed Jan 31, 2019
    The `post` key is part of the CircleCI 1.0 syntax is not available in the 2.0 syntax.
    
    PR Close #28472
Commits on Feb 19, 2019
  1. ci: add gkalpak and filipesilva to fw-dev-infra (#28807)

    filipesilva authored and IgorMinar committed Feb 18, 2019
    PR Close #28807
  2. feat(compiler-cli): make enableIvy ngtsc/true equivalent (#28616)

    filipesilva authored and IgorMinar committed Feb 8, 2019
    Currently setting `enableIvy` to true runs a hybrid mode of `ngc` and `ngtsc`. This is counterintuitive given the name of the flag itself.
    
    This PR makes the `true` value equivalent to the previous `ngtsc`, and `ngtsc` becomes an alias for `true`. Effectively this removes the hybrid mode as well since there's no other way to enable it.
    
    PR Close #28616
Commits on Feb 8, 2019
  1. ci: use fallback caches (#28545)

    filipesilva authored and mhevery committed Feb 5, 2019
    This PR adds fallback cache hits for partial cache restoration.
    
    PR Close #28545
Older
You can’t perform that action at this time.