Skip to content
Permalink
Branch: master
Commits on Apr 19, 2019
  1. build(docs-infra): upgrade cli command docs sources to 7e7a1aa5e (#29987

    gkalpak authored and benlesh committed Apr 19, 2019
    )
    
    Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
    
    ##
    Relevant changes in [commit range](angular/cli-builds@664990c...7e7a1aa):
    
    **Modified**
    - help/analytics.json
    - help/build.json
    - help/generate.json
    
    ##
    Relevant changes in [commit range](angular/cli-builds@437e037...7e7a1aa) since PR #29954:
    
    **Modified**
    - help/generate.json
    
    ##
    Closes #29954
    
    PR Close #29987
  2. ci(docs-infra): increase wait for SW on all origins to avoid CI flakes (

    gkalpak authored and benlesh committed Apr 19, 2019
    #29988)
    
    In #29953, the wait period for SW on localhost was increased to avoid CI
    flakes for the PWA score tests.
    
    This commit expands the fix to non-localhost origins to avoid flakes in
    the `aio_monitoring` job, when CircleCI VMs/network are slow.
    (For reference, example failures: [289127], [289238])
    
    [289127]: https://circleci.com/gh/angular/angular/289127
    [289238]: https://circleci.com/gh/angular/angular/289238
    
    PR Close #29988
  3. build(docs-infra): make tsconfig path detection in `switch-to-ivy` mo…

    gkalpak authored and benlesh committed Apr 19, 2019
    …re robust (#29989)
    
    In light of #29926, that will change the path of `tsconfig.app.json`,
    this commit switches from a hard-coded `tsconfig.app.json` path to
    looking it up in `angular.json` (to be more future-proof).
    
    PR Close #29989
  4. build(docs-infra): change `build-with-ivy` script to `switch-to-ivy` (#…

    gkalpak authored and benlesh committed Apr 2, 2019
    …29989)
    
    Previously, the `build-with-ivy` script could be used to build the `aio`
    project with Ivy (once it had been prepared with `ivy-ngcc`, etc.) and
    then restored the configuration (e.g. `tsconfig.json`) to non-ivy mode.
    
    As a result, it was not useful for running other commands (e.g. unit/e2e
    tests) in Ivy mode.
    
    This commit renames the script to `switch-to-ivy` and employs a
    different model (similar to `ng-packages-installer`), where the project
    is setup to run in Ivy mode and then all subsequent commands are
    executed in that mode (until restored).
    
    Since this is currently only used on CI, there is no automatic way to
    switch back to non-ivy mode (but it could be implemented in the future
    if needed).
    
    Finally, the script now modifies `src/tsconfig.app/json` instead of
    `tsconfig.json` to ensure that the `angularCompilerOptions` are not
    ignored/overwritten. This is also closer to what the cli generates
    with the `--enable-ivy` option.
    
    PR Close #29989
  5. ci(docs-infra): use pre-ivy packages in `test_aio_local_ivy` to test …

    gkalpak authored and benlesh committed Apr 2, 2019
    …ngcc (#29989)
    
    To better test ngcc (in addition to Ivy) on angular.io, change the
    `test_aio_local_ivy` CircleCI job to use the pre-ivy Angular packages
    (and have ngcc transform them to Ivy ones).
    
    PR Close #29989
Commits on Apr 17, 2019
  1. ci(docs-infra): increase wait for SW on localhost to avoid CI flakes (#…

    gkalpak authored and benlesh committed Apr 17, 2019
    …29953)
    
    The server used for testing on localhost has less optimizations (e.g.
    serves uncompressed files), so we need to wait longer the ServiceWorker
    to be loaded and registered to allow Lighthouse to reliably detect it,
    especially on slower environments (e.g. CI).
    
    Related: GoogleChrome/lighthouse#5527 (comment)
    
    Fixes #29910
    
    PR Close #29953
Commits on Apr 15, 2019
  1. ci(docs-infra): temporarily lower the min required PWA score for loca…

    gkalpak authored and alxhub committed Apr 15, 2019
    …lhost tests (#29911)
    
    The PWA score tests have been occasionally failing on CI recently
    (possibly due to CI VM/network issues).
    
    This commit temporarily disables them, until we investigate the
    root-cause and/or put a work-around in place.
    
    The PWA score tests are still run against the deployed versions (which
    don't suffer as much) or PRs with public previews (as part of the
    `test_aio_preview` job) and on upstream builds (as part of the
    `deploy_aio` job).
    
    Related to #29910.
    
    [1]: https://github.com/angular/angular/blob/3a836c362/.circleci/config.yml#L390
    
    PR Close #29911
  2. fix(docs-infra): add missing ng-conf image (#29902)

    gkalpak authored and alxhub committed Apr 15, 2019
    As of b9fead7, the image is referenced in `announcements.json`, but it
    was already removed (as it wasn't used at the time) in 7f905da.
    
    PR Close #29902
  3. build(docs-infra): add missing dependencies (chrome-launcher, lightho…

    gkalpak authored and alxhub committed Apr 15, 2019
    …use-logger) (#29904)
    
    We are using `chrome-launcher` and `lighthouse-logger` in
    [test-pwa-score][1], but we do not explicitly list them as
    `devDependencies`, so we are relying on the fact that they happen to be
    hoisted in `node_modules/` by yarn. This may unexpectedly break in the
    future.
    
    This commit fixes this, by explicitly listing them as `devDependencies`.
    
    [1]: https://github.com/angular/angular/blob/ea70d41ac/aio/scripts/test-pwa-score.js#L14-L18
    
    PR Close #29904
  4. build(docs-infra): upgrade lighthouse to 4.3.0 (#29904)

    gkalpak authored and alxhub committed Apr 15, 2019
    Also, log the Lighthouse version in `test-pwa-score` to aid in
    debugging.
    
    PR Close #29904
Commits on Apr 11, 2019
  1. ci: correctly detect status 400 as failure in `get-commit-range` (#29839

    gkalpak authored and IgorMinar committed Apr 11, 2019
    )
    
    PR Close #29839
  2. build(docs-infra): upgrade cli command docs sources to 664990cad (#29827

    gkalpak authored and IgorMinar committed Apr 11, 2019
    )
    
    Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
    
    ##
    Relevant changes in [commit range](angular/cli-builds@b00300e...664990c):
    
    **Modified**
    - help/build.json
    - help/generate.json
    - help/new.json
    - help/serve.json
    - help/test.json
    
    ##
    
    PR Close #29827
Commits on Apr 8, 2019
  1. refactor(docs-infra): rename properties (blacklisted --> ignored) (#2…

    gkalpak authored and IgorMinar committed Apr 7, 2019
    …9754)
    
    PR Close #29754
  2. build(docs-infra): do not include `announcements.json` in sitemap (#2…

    gkalpak authored and IgorMinar committed Apr 7, 2019
    …9754)
    
    The `announcements.json` file should not be included in the sitemap and
    including it causes an error in Google Search Console (because the
    generated URL does not exist).
    
    (This is a follow-up to fbef94a.)
    
    PR Close #29754
Commits on Apr 3, 2019
  1. build(docs-infra): upgrade cli command docs sources to b00300ebd (#29679

    gkalpak authored and jasonaden committed Apr 3, 2019
    )
    
    Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
    Relevant changes in [commit range](angular/cli-builds@f63f8c6...b00300e):
    
    **Modified**
    - help/build.json
    - help/generate.json
    
    PR Close #29679
Commits on Apr 2, 2019
  1. ci: fix CODEOWNERS for ngcc (#29660)

    gkalpak authored and jasonaden committed Apr 2, 2019
    With a770aa2, ngcc was moved to a different directory
    (`compiler/src/ngcc/` --> `compiler/ngcc/`), but the `CODEOWNERS` file
    was not updated to reflect that.
    PR Close #29660
  2. fix(docs-infra): fix scroll position restoration error in `ScrollServ…

    gkalpak authored and jasonaden committed Apr 2, 2019
    …ice` (#29658)
    
    Based on Google Analytics error report, the following error happens
    occasionally (15% or total errors for 2019-03):
    
    ```
    Cannot read property '0' of null TypeError: at t.scrollToPosition@main.js
    ```
    
    This was a result of calling [ViewportScroller#scrollToPosition()][1]
    with `null`, which in turn happens when calling
    [ScrollService#scrollToPosition()][2] while `this.scrollPosition` is
    `null`. This can be a result of a `popstate` event without an associated
    history state.
    
    This commit fixes the error by checking whether `this.scrollPosition` is
    `null`, before using it with `scrollToPosition()`.
    
    (It also refactors away the unneeded internal `popStateFired` property.)
    
    [1]: https://github.com/angular/angular/blob/deca6a60d/packages/common/src/viewport_scroller.ts#L101-L105
    [2]: https://github.com/angular/angular/blob/deca6a60d/aio/src/app/shared/scroll.service.ts#L158-L161
    
    PR Close #29658
Commits on Apr 1, 2019
  1. test(docs-infra): avoid click-related CI flake in e2e test (#29641)

    gkalpak authored and jasonaden committed Apr 1, 2019
    One of the tests introduced in #29601 is susceptible to a kind of
    WebDriver flake related to trying to click elements hidden behind fixed
    positioned elements.
    This commit works around the issue by clicking the elements directly
    using JavaScript (instead of `WebElement#click()`).
    
    PR Close #29641
  2. docs: update CODEOWNERS with missing or removed guides/examples (#29612)

    gkalpak authored and jasonaden committed Mar 30, 2019
    PR Close #29612
  3. test(docs-infra): add e2e test for the contributors page (#29601)

    gkalpak authored and jasonaden committed Mar 29, 2019
    Previously, if the shape of data in `contributors.json` was incorrect,
    there would be a runtime error (when trying to parse the data), which
    would result in a blank page. The likelihood for this happening is
    higher after #29553, where the shape of data changed.
    
    This commit adds some basic e2e tests that verify the page works as
    expected and there are contributors listed.
    
    PR Close #29601
  4. test(upgrade): work around SauceLabs issue with loading AngularJS fil…

    gkalpak authored and jasonaden committed Mar 29, 2019
    …es (#29603)
    
    Sometimes (especially on mobile browsers on SauceLabs) the script may
    fail to load due to a temporary issue with the internet connection. To
    avoid flakes on CI when this happens, we retry the download after some
    delay.
    
    Related to #28578.
    
    PR Close #29603
  5. build(docs-infra): remove unused `PhantomJS` dependency (#29611)

    gkalpak authored and jasonaden committed Mar 30, 2019
    PhantomJS is [not being developed any more][1] and with modern
    alternatives (such as Chrome headless) there is no reason to keep it as
    a dependency.
    
    [1]: ariya/phantomjs#15344
    
    PR Close #29611
  6. build(docs-infra): upgrade cli command docs sources to f63f8c60f (#29618

    gkalpak authored and jasonaden committed Mar 31, 2019
    )
    
    Updating [angular#master](https://github.com/angular/angular/tree/master) from [cli-builds#master](https://github.com/angular/cli-builds/tree/master).
    Relevant changes in [commit range](angular/cli-builds@35df0b5...f63f8c6):
    
    **Modified**
    - help/build.json
    
    Closes #29607
    
    PR Close #29618
Commits on Mar 29, 2019
  1. build(docs-infra): add check to ensure all contributor pictures exist (

    gkalpak authored and jasonaden committed Mar 29, 2019
    …#29553)
    
    PR Close #29553
  2. docs: add Sam Julien to GDE group as well (#29553)

    gkalpak authored and jasonaden committed Mar 29, 2019
    PR Close #29553
  3. docs: change the order of groups in contributors page (#29553)

    gkalpak authored and jasonaden committed Mar 29, 2019
    Put "Collaborators" before "GDE", since they are semantically closer to
    the core team.
    
    PR Close #29553
  4. docs: change heading of contributors page to avoid confusion (Collabo…

    gkalpak authored and jasonaden committed Mar 29, 2019
    …rators --> Contributors) (#29553)
    
    Now that "Collaborators" is a separate group in the contributors page,
    having "Angular Collaborators" as the heading of the page (which also
    contains the "Angular" and "GDE" groups) is confusing.
    Changing the title to "Angular Contributors" to avoid confusion.
    
    PR Close #29553
  5. docs: change contributor group name (Collaborator --> Collaborators) (#…

    gkalpak authored and jasonaden committed Mar 29, 2019
    …29553)
    
    The name of the group also serves as the group tab's title in the docs
    app and having "Collaborator" (singular) as a title for a list of people
    didn't read well.
    Changing th group name (and thus tab title) to "Collaborators" (plural).
    
    PR Close #29553
Older
You can’t perform that action at this time.