Skip to content
Permalink
Branch: master
Commits on Jun 25, 2019
  1. build: fix build failures with worker mode cache and @types/events (#…

    gregmagolan authored and kara committed Jun 22, 2019
    …31019)
    
    Errors observed only in tests on CircleCI — was not reproducible locally.
    
    ```
    ERROR: /home/circleci/ng/packages/http/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/http/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
      (cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
      exec env - \
        BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
        PATH=/bin:/usr/bin:/usr/local/bin \
      bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/http/test/test_lib_es5_tsconfig.json)
    Execution platform: //tools:rbe_ubuntu1604-angular
    Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts.
    
    ERROR: /home/circleci/ng/packages/benchpress/test/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/benchpress/test:test_lib failed (Exit 1): tsc_wrapped failed: error executing command
      (cd /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular && \
      exec env - \
        BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1 \
        PATH=/bin:/usr/bin:/usr/local/bin \
      bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped @@bazel-out/k8-fastbuild/bin/packages/benchpress/test/test_lib_es5_tsconfig.json)
    Execution platform: //tools:rbe_ubuntu1604-angular
    Compilation failed Error: missing input digest for /home/circleci/.cache/bazel/_bazel_circleci/9ce5c2144ecf75d11717c0aa41e45a8d/execroot/angular/external/npm/node_modules/@types/events/index.d.ts
    
    ERROR: C:/codefresh/volume/angular/packages/compiler/test/css_parser/BUILD.bazel:3:1: Compiling TypeScript (devmode) //packages/compiler/test/css_parser:css_parser_lib failed (Exit 1):
    tsc_wrapped.exe failed: error executing command
      cd C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular
      SET PATH=C:\msys64\usr\bin;C:\msys64\bin;C:\Windows;C:\Windows\System32;C:\Windows\System32\WindowsPowerShell\v1.0
        SET RUNFILES_MANIFEST_ONLY=1
      bazel-out/host/bin/external/npm/@bazel/typescript/bin/tsc_wrapped.exe @@bazel-out/x64_windows-fastbuild/bin/packages/compiler/test/css_parser/css_parser_lib_es5_tsconfig.json
    Execution platform: @bazel_tools//platforms:host_platform
    Compilation failed Error: missing input digest for C:/users/containeradministrator/_bazel_containeradministrator/zquin2l6/execroot/angular/external/npm/node_modules/@types/events/index.
    d.ts
    ```
    
    PR Close #31019
  2. build(bazel): update //packages/bazel/test/ngc-wrapped:ngc_test test (#…

    gregmagolan authored and kara committed Jun 20, 2019
    …31019)
    
    after update to rules_nodejs 0.32.1, @types are no longer automatically discovered by ngc-wrapped (which uses parts of ts_library) so this test needed updating so that the types files it generates is added as an explicit dep
    
    PR Close #31019
  3. build(bazel): add build --incompatible_list_based_execution_strategy_…

    gregmagolan authored and kara committed Jun 20, 2019
    …selection=false flag (#31019)
    
    This option is changed to true in Bazel 0.27 and exposes a possible
    regression in Bazel 0.27.0.
    Error observed is in npm_package target `//packages/common/locales:package`:
    ```
    ERROR: /home/circleci/ng/packages/common/locales/BUILD.bazel:13:1: Assembling
    npm package packages/common/locales/package failed: No usable spawn strategy found
    for spawn with mnemonic SkylarkAction.  Your --spawn_strategyor --strategy flags
    are probably too strict. Visit bazelbuild/bazel#7480 for
    migration advises
    ```
    Suspect is https://github.com/bazelbuild/rules_nodejs/blob/master/internal/npm_package/npm_package.bzl#L75-L82:
    ```
     execution_requirements = {
        # Never schedule this action remotely because it's not computationally expensive.
        # It just copies files into a directory; it's not worth copying inputs and outputs to a remote worker.
        # Also don't run it in a sandbox, because it resolves an absolute path to the bazel-out directory
        # allowing the .pack and .publish runnables to work with no symlink_prefix
        # See bazelbuild/rules_nodejs#187
        "local": "1",
    },
    ```
    
    PR Close #31019
  4. build: disable must-use-promises check in ts_library tsetse for tests…

    gregmagolan authored and kara committed Jun 19, 2019
    … as... (#31019)
    
    ...tsetse now falsely asserting on  some lines in a few tests such as packages/core/schematics/test/injectable_pipe_migration_spec.ts.
    
    ```
        await runMigration();
        expect(tree.readContent('/index.ts'))
    ```
    
    it asserts that "await is required on promise" on the 2nd line when there is no promise there
    
    PR Close #31019
  5. build(bazel): cleanup entry_point target (#31019)

    gregmagolan authored and kara committed Jun 21, 2019
    PR Close #31019
  6. build: update to rules_nodejs 0.32.2 (#31019)

    gregmagolan authored and kara committed Jun 19, 2019
    Brings in ts_library fixes required to get angular/angular building after 0.32.0:
    typescript: exclude typescript lib declarations in node_module_library transitive_declarations
    typescript: remove override of @bazel/tsetse (+1 squashed commit)
    
    @npm//node_modules/foobar:foobar.js labels changed to @npm//:node_modules/foobar/foobar.js with fix for bazelbuild/rules_nodejs#802
    
    also updates to rules_rass commit compatible with rules_nodejs 0.32.0
    
    PR Close #31019
  7. build(bazel): update to bazel 0.27.0 and fix compat in @angular/bazel…

    gregmagolan authored and kara committed Jun 13, 2019
    … package (#31019)
    
    ctx.actions.declare_file now used in @angular/bazel ng_module rule as ctx.new_file is now deprecated. Fixes error:
    
    ```
            File "ng_module.bzl", line 272, in _expected_outs
                    ctx.new_file(ctx.genfiles_dir, (ctx.label.name ..."))
    Use ctx.actions.declare_file instead of ctx.new_file.
    Use --incompatible_new_actions_api=false to temporarily disable this check.
    ```
    
    This can be worked around with incompatible_new_actions_api flag but may as well fix it proper so downstream doesn't require this flag due to this code.
    
    Also, depset() is no longer iterable by default without a flag. This required fixing in a few spots in @angular/bazel.
    
    fix: foo
    
    PR Close #31019
Commits on Jun 11, 2019
  1. build: set symlink_node_modules = False for yarn_install in main WORK…

    gregmagolan authored and IgorMinar committed Jun 10, 2019
    …SPACE and bazel schematics (#30627)
    
    This is needed to work-around issue: yarn_install & npm_install with managed directories can't handle deleted or manually regenerated node_modules folder [bazelbuild/rules_nodejs#802]
    Underlying issue has been fixed in Bazel bazelbuild/bazel#8487 but hasn't landed in a release yet
    
    PR Close #30627
  2. build(bazel): update to nodejs rules 0.31.1 (#30627)

    gregmagolan authored and IgorMinar committed Jun 7, 2019
    * entry_point attribute of nodejs_binary & rollup_bundle is now a label
    * symlinking of node_modules for yarn_install temporarily disabled (except for integration/bazel) until the fix for bazelbuild/bazel#8487 makes it into a future bazel release
    
    PR Close #30627
  3. build(bazel): update to nodejs rules 0.30.1 & bazel 0.26.0 (#30627)

    gregmagolan authored and IgorMinar committed May 23, 2019
    nodejs rules 0.30.1 has new feature to symlink node_modules with yarn_install and bazel 0.26.0 includes new managed_directories feature which enables this
    
    PR Close #30627
Commits on May 16, 2019
  1. build(bazel): update to latest stable chromium 74 on osx and linux fo…

    gregmagolan authored and jasonaden committed May 16, 2019
    …r karma under bazel (#30502)
    
    We were on 69 for both of these platforms which is fairly old. This update also requires a temporary patch to the @bazel/karma npm package to disable chrome sandboxing on OSX as it is broken under Bazel as of chromium 73. Windows is still on Chromium 66 but updating this will require upstream changes to rules_webtesting as the archive name & executable name has changed as of 72 for Windows and hard-coded paths in rules_webtesting break things.
    
    PR Close #30502
Commits on Apr 25, 2019
  1. fix(bazel): transitive npm deps in ng_module (#30065)

    gregmagolan authored and AndrewKushnir committed Apr 23, 2019
    BREAKING CHANGE:
    
    ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12
    
    PR Close #30065
Commits on Apr 17, 2019
  1. build(bazel): fix missing deps in ts_devserver targets under /modules…

    gregmagolan authored and benlesh committed Apr 11, 2019
    …/playground/src/web_workers (#29799)
    
    PR Close #29799
  2. build(bazel): fix deps of test (#29799)

    gregmagolan authored and benlesh committed Apr 10, 2019
    PR Close #29799
  3. build(bazel): update to nodejs rules 0.27.12 and pin versions in @ang…

    gregmagolan authored and benlesh committed Apr 10, 2019
    …ular/bazel peer deps and for @bazel/schematics (#29799)
    
    PR Close #29799
Commits on Apr 10, 2019
  1. build(bazel): pin versions of nodejs rules in @angular/bazel peer dep…

    gregmagolan authored and kara committed Apr 10, 2019
    …s and @bazel/schematics (#29800)
    
    PR Close #29800
Commits on Apr 4, 2019
  1. build(bazel): tslib.js still required in ts_devserver & ts_web_test_s…

    gregmagolan authored and IgorMinar committed Apr 4, 2019
    …uite for schematics (#29694)
    
    PR Close #29694
  2. build(bazel): remove unnecessary scripts from ts_devserver & ts_web_t…

    gregmagolan authored and IgorMinar committed Apr 4, 2019
    …est_suite in bazel schematics (#29694)
    
    PR Close #29694
  3. build(bazel): remove unnecessary scripts from ts_devserver & ts_web_t…

    gregmagolan authored and IgorMinar committed Apr 4, 2019
    …est_suite in /integration/bazel (#29694)
    
    PR Close #29694
  4. fix(bazel): add configuration_env_vars = ["compile"] to generated @np…

    gregmagolan authored and IgorMinar committed Apr 3, 2019
    …m//@angular/bazel/bin:ngc-wrapped nodejs_binary (#29694)
    
    PR Close #29694
Commits on Apr 2, 2019
  1. build(bazel): update to nodejs rules 0.27.9 (#29647)

    gregmagolan authored and jasonaden committed Apr 1, 2019
    PR Close #29647
Commits on Mar 27, 2019
  1. build(bazel): update integration/bazel lock file (#29508)

    gregmagolan authored and mhevery committed Mar 25, 2019
    PR Close #29508
  2. build(bazel): update to nodejs rules 0.27.8 (#29508)

    gregmagolan authored and mhevery committed Mar 25, 2019
    * fixes prodmode issue in integration/bazel
    
    BREAKING CHANGE:
    
    @bazel/typescript is now a peerDependency of @angular/bazel so user's of @angular/bazel must add @bazel/typescript to their package.json
    
    PR Close #29508
Commits on Mar 21, 2019
  1. build: add @npm//jasmine-core dep back to jasmine_node_test in defaul…

    gregmagolan authored and kara committed Mar 21, 2019
    …ts.bzl (#29444)
    
    PR Close #29444
Commits on Mar 20, 2019
  1. build(bazel): add comment about advancing the version of yarn used un…

    gregmagolan authored and matsko committed Mar 20, 2019
    …der Bazel in the future (#29431)
    
    PR Close #29431
  2. build(bazel): revert back to yarn 1.12.1 under Bazel to fix Windows f…

    gregmagolan authored and matsko committed Mar 20, 2019
    …ile-in-use issues (#29431)
    
    PR Close #29431
  3. build(bazel): fix router test failure (#29375)

    gregmagolan authored and matsko committed Mar 19, 2019
    PR Close #29375
  4. build(bazel): update to nodejs rules 0.27.7 (#29375)

    gregmagolan authored and matsko committed Mar 19, 2019
    PR Close #29375
  5. build(bazel): fix jasmine_node_test defaults (#29375)

    gregmagolan authored and matsko committed Mar 18, 2019
    PR Close #29375
Older
You can’t perform that action at this time.